Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add XDC Blockchain #941

Closed
wants to merge 1 commit into from
Closed

Add XDC Blockchain #941

wants to merge 1 commit into from

Conversation

AnilChinchawale
Copy link

@AnilChinchawale AnilChinchawale commented May 4, 2020 •
edited
Loading

Description

Extended Wallet-core with blockchain & coin XDC.

Testing instructions

  • Interacted with WalletConsole
  • Verify tests

Types of changes

New feature (non-breaking change, Added as per docs.)

Checklist

  • Prefix PR title with [WIP] if necessary.
  • Add tests to cover changes as needed.
  • Update documentation as needed.
  • If there is a related Issue, mention it in the description (e.g. 'Fixes Adopt Zilliqa to bech32 address format #444 ).

@hewigovens hewigovens closed this May 4, 2020
@AnilChinchawale
Copy link
Author

Can you give me details reason to close this PR?

@hewigovens
Copy link
Contributor

hewigovens commented May 5, 2020 •
edited by unfurl-links bot
Loading

  1. doesn't match: https://developer.trustwallet.com/wallet-core/newblockchain#integration-criteria
  2. all CI were failed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@optout21 optout21 Awaiting requested review from optout21

@hewigovens hewigovens Awaiting requested review from hewigovens

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adopt Zilliqa to bech32 address format
2 participants
@AnilChinchawale @hewigovens