-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Bitcoin Gold implementation #926
Conversation
Maybe flaky CI errors? |
Codecov Report
@@ Coverage Diff @@
## master #926 +/- ##
==========================================
+ Coverage 93.30% 93.37% +0.06%
==========================================
Files 418 424 +6
Lines 12167 12384 +217
==========================================
+ Hits 11353 11564 +211
- Misses 814 820 +6
Continue to review full report at Codecov.
|
Hi, We have no plan to add BTG (or other bitcoin forks) to Trust Wallet |
The iOS CI build failed with this error:
Maybe BitcoinGold? |
The Linux CI build failure is infrastructure-related, we will check. |
Hi @hewigovens, yeah, we fully understood that. We checked the integration guidance and our first thought was that merging it into wallet-core could benefit more projects and the open source blockchain space, even given TrustWallet is not going to add it. Btw would you mind introduce us the go-to person for a chat? We would really appreciate it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing lock script / zpub tests:
https://developer.trustwallet.com/wallet-core/newblockchain#bitcoin-forks-checklist
/azp run |
Added at 11aa44f. Please take a look :) |
please rebase master, Android CI should be fixed |
Add mainnet transaction url Co-Authored-By: hewig <[email protected]>
Looks like we are ready to go :) |
Description
(Update since #911: fixed android and ios integration tests)
Bitcoin Gold is already added to the trustwallet/assets. This PR adds the implementation including the address codec and transaction signing logic.
Testing instructions
Passes unit tests:
./build/tests/tests tests
Create a new address in walletconsole:
Types of changes
Checklist
[WIP]
if necessary.