Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CMake config to use relative subdirectories #905

Closed
wants to merge 1 commit into from
Closed

Update CMake config to use relative subdirectories #905

wants to merge 1 commit into from

Conversation

pavel-bc
Copy link
Contributor

Description

This to be able to use CMake project as a git submodule

Testing instructions

Types of changes

Checklist

  • Prefix PR title with [WIP] if necessary.
  • Add tests to cover changes as needed.
  • Update documentation as needed.
  • If there is a related Issue, mention it in the description (e.g. 'Fixes Adopt Zilliqa to bech32 address format #444 ).

@hewigovens
Copy link
Contributor

If you want to support building as submodule, you should define an environment variable instead change the root directory, what if submodule name is not wallet-core?

@hewigovens hewigovens closed this Mar 28, 2020
@pavel-bc
Copy link
Contributor Author

@hewigovens Good point!

@pavel-bc pavel-bc deleted the fix/cmake-config-relative branch March 28, 2020 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adopt Zilliqa to bech32 address format
2 participants
@pavel-bc @hewigovens