Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update newcoin script to auto include coin entry include and creation. #891

Merged
merged 1 commit into from
Mar 19, 2020

Conversation

optout21
Copy link
Contributor

Description

In new coin templating script newcoin include to automatically add the needed lines to src/Coin.cpp: an include and an instance creation line. Fixes #886 .

Testing instructions

  • Clean workspace
  • Add new Dummy coin to coins.json
  • run codegen/bin/newcoin dummy
  • check resulting Coin.cpp, build, etc.

Types of changes

Checklist

  • Prefix PR title with [WIP] if necessary.
  • Add tests to cover changes as needed.
  • Update documentation as needed.
  • If there is a related Issue, mention it in the description (e.g. 'Fixes Adopt Zilliqa to bech32 address format #444 ).

@optout21 optout21 requested a review from hewigovens March 18, 2020 09:36
@codecov
Copy link

codecov bot commented Mar 18, 2020

Codecov Report

Merging #891 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #891   +/-   ##
=======================================
  Coverage   92.41%   92.41%           
=======================================
  Files         417      417           
  Lines       12040    12040           
=======================================
  Hits        11127    11127           
  Misses        913      913
Impacted Files Coverage Δ
src/Coin.cpp 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 587e10b...14e4401. Read the comment docs.

@optout21 optout21 merged commit 83079c4 into master Mar 19, 2020
@optout21 optout21 deleted the ar/newcoin branch March 19, 2020 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants