NAS-132648 / 25.04 / query param handling for auth tokens

[aervin]

Changes:

Testing:
One method:

• clear localStorage
• you'll have to comment out the https: check in AuthService.setQueryToken
• midclt call auth.generate_token
• append the token to an app route: localhost:4200/storage/disks?token=<token>

Downstream

Affects	Reasoning
Documentation

[bugclerk]

Jira URL: https://ixsystems.atlassian.net/browse/NAS-132648

[aervin]

The approach so far is to forward query params on redirect to /signin (AuthGuardService:canActivate). From there, add a bit of logic to signin.store and auth.service to handle the token.

However, this isn't working like I'd expect. Seems that WebsocketHandlerService is calling its resetUI method and interfering with the redirect.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.33%. Comparing base (cf486c8) to head (911e1d4).
Report is 19 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files

@@            Coverage Diff             @@
##           master   #11080      +/-   ##
==========================================
- Coverage   82.35%   82.33%   -0.02%     
==========================================
  Files        1630     1644      +14     
  Lines       57229    57522     +293     
  Branches     5915     5933      +18     
==========================================
+ Hits        47130    47362     +232     
- Misses      10099    10160      +61     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[undsoft]

Seems to be redirecting fine for me:

2024-11-21.11.03.57.mov

[undsoft]

BTW, I don't know if tokens in browser history is kosher.

[undsoft]

The code looks good, but I just couldn't get it to work on a CI machine.
I can see token being sent to middleware, but it just returns AUTH_ERR for some reason.