NAS-132446 / 24.10.1 / Initial add of option to use internal APT repo for builds (by kmoore134) #757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or builds (#754) * Initial add of option to use internal APT repo for builds * Pet flake8 * Wrap a long f-string * Use f-string in right place * Fix usage of single / double quotes * Move to apt_get_base_url as a function * Undo dyslexia * Log which base url we are using in bootstrap for debugging * Add missing location to use the base url in bootstrap * Use base url when bootstrapping the ISO as well * Add APT_BASE_CUSTOM as another override option if the builder wants to pull from some location other than the two in our manifest (cherry picked from commit 5f95982)
yocalebo
force-pushed
the
NAS-132446-24.10.1
branch
from
3605177 to
ee8d96b
Compare
yocalebo
approved these changes
Nov 14, 2024
|
This PR has been merged and conversations have been locked. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an option to set APT_INTERNAL_BUILD in the environment, which will toggle the builder to use the CDN Apt, or the iX Internal Apt Repo.
Additionally, the environment variable APT_BASE_CUSTOM can be set to a URL if you wish to override both options to pull from another location at build time.
Original PR: #754
Jira URL: https://ixsystems.atlassian.net/browse/NAS-132446