Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-132195 / 25.04 / Improve audit HA test #15077

Merged
merged 2 commits into from
Dec 3, 2024
Merged

NAS-132195 / 25.04 / Improve audit HA test #15077

merged 2 commits into from
Dec 3, 2024

Conversation

mgrimesix
Copy link
Contributor

Every once in a while the basic HA audit test would fail. Possibly because earlier tests generated audit events that confused this test. Possibly because the remote node was slow to respond.

This PR addresses both conditions by improving the query filter and adding a couple more retry loops.
Also improved the assert output in case more tweaks are necessary.

Test results are here.

@mgrimesix mgrimesix requested a review from a team December 3, 2024 02:08
@bugclerk bugclerk changed the title Improve audit HA test NAS-132195 / 25.04 / Improve audit HA test Dec 3, 2024
@bugclerk
Copy link
Contributor

bugclerk commented Dec 3, 2024

@mgrimesix mgrimesix merged commit 3be947d into master Dec 3, 2024
2 of 3 checks passed
@mgrimesix mgrimesix deleted the NAS-132195 branch December 3, 2024 15:23
@bugclerk
Copy link
Contributor

bugclerk commented Dec 3, 2024

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Dec 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants