Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-132823 / 25.04 / Convert SMB share ACL methods to api_method #15075

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

anodos325
Copy link
Contributor

This commit convert smb.getacl and smb.setacl to new api_method.

This commit convert smb.getacl and smb.setacl to new api_method.
@bugclerk
Copy link
Contributor

bugclerk commented Dec 2, 2024

@bugclerk bugclerk changed the title Convert SMB share ACL methods to api_method NAS-132823 / 25.04 / Convert SMB share ACL methods to api_method Dec 2, 2024
Copy link
Contributor

@mgrimesix mgrimesix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anodos325 anodos325 merged commit 2670e83 into master Dec 2, 2024
2 of 3 checks passed
@anodos325 anodos325 deleted the smb-acl-api_method branch December 2, 2024 21:21
@bugclerk
Copy link
Contributor

bugclerk commented Dec 2, 2024

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Dec 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants