-
Notifications
You must be signed in to change notification settings - Fork 492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NAS-130745 / 25.04 / Update smartctl usage to use JSON #14479
Conversation
ab0d655
to
fa3011d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job! There are some details I want to pay attention too.
New passing tests! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good, only minor issues are left
This PR has been merged and conversations have been locked. |
I've updated our smartctl usage throughout middleware to use the JSON flag to get serialized data. Unfortunately I haven't been able to run this through a full gauntlet of SMART test types for different drives. Going through the smartmontools source code and doing what I can with different drive types I had available, I've gotten the JSON parsing as accurate as I could.
This is something that might end up breaking, but getting tickets will let us fix any assumed/implicit keys we're accessing.
Passing tests, but the majority are our
CI build
tests, which are passing.