Skip to content

Commit

Permalink
Do not report docker address pool as ip* objects in config (#15079)
Browse files Browse the repository at this point in the history
This commit adds changes to not report docker address pool fields as ip* objects for now, this would mean that all consumers would need to update their usages and we don't have a precedent yet in middleware - so for now we will report them as string as they were before.
  • Loading branch information
sonicaj authored Dec 3, 2024
1 parent eecc730 commit a0b7bd9
Showing 1 changed file with 8 additions and 6 deletions.
14 changes: 8 additions & 6 deletions src/middlewared/middlewared/api/v25_04_0/docker.py
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,14 @@ class DockerEntry(BaseModel):
dataset: NonEmptyString | None
pool: NonEmptyString | None
nvidia: bool
address_pools: list[dict]
cidr_v6: str


@single_argument_args('docker_update')
class DockerUpdateArgs(DockerEntry, metaclass=ForUpdateMetaclass):
id: Excluded = excluded_field()
dataset: Excluded = excluded_field()
address_pools: list[AddressPool]
cidr_v6: IPvAnyInterface

Expand All @@ -46,12 +54,6 @@ def validate_ipv6(cls, v):
return v


@single_argument_args('docker_update')
class DockerUpdateArgs(DockerEntry, metaclass=ForUpdateMetaclass):
id: Excluded = excluded_field()
dataset: Excluded = excluded_field()


class DockerUpdateResult(BaseModel):
result: DockerEntry

Expand Down

0 comments on commit a0b7bd9

Please sign in to comment.