Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Second-order Quadrilaterals (2D) meshes in standard Abaqus .inp format #2217

Open
wants to merge 43 commits into
base: main
Choose a base branch
from

Conversation

DanielDoehring
Copy link
Contributor

This implements second-order 2D quadrilateral p4est meshes constructed from a standard-format Abaqus .inp files.
See #1847 for this feature request.

Essentially, this PR is a bunch of tedious mesh file parsing to extract the relevant information. As in the existing implementation, we focus on meshes constructed e.g. from gmsh which are exported to .inp format.

For validation, I ran the simulation of a laminar, low Machnumber (essentially incompressible) simulation over the SD7003 airfoil.

The averaged drag & lift coefficient are

Average drag coefficient: 0.049819536195680685
Average lift coefficient: 0.3817639249290595

which are in excellent agreement with reference data (See this preprint)

Screenshot from 2024-12-20 14-06-44

Copy link
Contributor

Review checklist

This checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging.

Purpose and scope

  • The PR has a single goal that is clear from the PR title and/or description.
  • All code changes represent a single set of modifications that logically belong together.
  • No more than 500 lines of code are changed or there is no obvious way to split the PR into multiple PRs.

Code quality

  • The code can be understood easily.
  • Newly introduced names for variables etc. are self-descriptive and consistent with existing naming conventions.
  • There are no redundancies that can be removed by simple modularization/refactoring.
  • There are no leftover debug statements or commented code sections.
  • The code adheres to our conventions and style guide, and to the Julia guidelines.

Documentation

  • New functions and types are documented with a docstring or top-level comment.
  • Relevant publications are referenced in docstrings (see example for formatting).
  • Inline comments are used to document longer or unusual code sections.
  • Comments describe intent ("why?") and not just functionality ("what?").
  • If the PR introduces a significant change or new feature, it is documented in NEWS.md with its PR number.

Testing

  • The PR passes all tests.
  • New or modified lines of code are covered by tests.
  • New or modified tests run in less then 10 seconds.

Performance

  • There are no type instabilities or memory allocations in performance-critical parts.
  • If the PR intent is to improve performance, before/after time measurements are posted in the PR.

Verification

  • The correctness of the code was verified using appropriate tests.
  • If new equations/methods are added, a convergence test has been run and the results
    are posted in the PR.

Created with ❤️ by the Trixi.jl community.

Copy link

codecov bot commented Dec 20, 2024

Codecov Report

Attention: Patch coverage is 96.66667% with 7 lines in your changes missing coverage. Please review.

Project coverage is 96.42%. Comparing base (a1be62b) to head (acd774e).

Files with missing lines Patch % Lines
src/meshes/p4est_mesh.jl 96.41% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2217      +/-   ##
==========================================
- Coverage   96.42%   96.42%   -0.00%     
==========================================
  Files         486      487       +1     
  Lines       39164    39352     +188     
==========================================
+ Hits        37761    37942     +181     
- Misses       1403     1410       +7     
Flag Coverage Δ
unittests 96.42% <96.67%> (-<0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sloede
Copy link
Member

sloede commented Dec 20, 2024

This implements second-order 2D quadrilateral p4est meshes constructed from a standard-format Abaqus .inp files.

This is so awesome! Thanks a lot for this very cool feature 💪♥️

Copy link
Member

@andrewwinters5000 andrewwinters5000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this feature! Overall the new file reading and constructors look good. I just left some questions about naming and future functionality.

NEWS.md Outdated Show resolved Hide resolved
docs/src/meshes/p4est_mesh.md Show resolved Hide resolved
src/meshes/p4est_mesh.jl Outdated Show resolved Hide resolved
src/meshes/p4est_mesh.jl Outdated Show resolved Hide resolved
src/meshes/p4est_mesh.jl Show resolved Hide resolved
src/meshes/p4est_mesh.jl Show resolved Hide resolved
src/meshes/p4est_mesh.jl Show resolved Hide resolved
src/meshes/p4est_mesh.jl Outdated Show resolved Hide resolved
src/meshes/p4est_mesh.jl Show resolved Hide resolved
NEWS.md Outdated Show resolved Hide resolved
@DanielDoehring DanielDoehring added the enhancement New feature or request label Dec 29, 2024
Copy link
Member

@andrewwinters5000 andrewwinters5000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ranocha
Copy link
Member

ranocha commented Jan 9, 2025

Feel free to merge this when CI passes. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants