Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AMD] Upgrade AMD CI docker image #5230

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

AlexAUT
Copy link
Contributor

@AlexAUT AlexAUT commented Nov 22, 2024

As discussed in #5005 this PR just lands the updated docker image and fixes for proton test cases for rocm6.2.

This also switches to ubuntu's default clang toolchain instead of using the one which comes with rocm.

New contributor declaration

  • I am not making a trivial change, such as fixing a typo in a comment.

  • I have written a PR description following these
    rules.

  • I have run pre-commit run --from-ref origin/main --to-ref HEAD.

  • Select one of the following.

    • I have added tests.
      • /test for lit tests
      • /unittest for C++ tests
      • /python/test for end-to-end tests
    • This PR does not need a test because It does not touch code.
  • Select one of the following.

    • I have not added any lit tests.
    • The lit tests I have added follow these best practices,
      including the "tests should be minimal" section. (Usually running Python code
      and using the instructions it generates is not minimal.)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is changes in this file necessary? Can we separate it out to another pull request?

Copy link
Contributor Author

@AlexAUT AlexAUT Nov 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can separate it into another PR but it needs to be merged first. Without the proton changes the tests will fail when upgrading to rocm 6.2.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will rebase this branch once #5252 has landed. The commit/changes will then disappear.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants