Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Refactor of L0_backend_python and the env subtest #7838

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

nv-kmcgill53
Copy link
Contributor

What does the PR do?

This PR refactors the L0_backend_python test to be able to incrementally run different parts of the test by using variables rather than having to comment out large sections of code.

Additionally this PR also refactors the env subtest to make use of configurable variables to run certain parts of the test on demand. This allows the L0_backend_python test to potentially be parallelized in the CI. This also turns silent failures into verbose failures, such as the Locale test in the env subtest currently failing even thought the CI says it's passing.

Checklist

  • PR title reflects the change and is of format <commit_type>: <Title>
  • Changes are described in the pull request.
  • Related issues are referenced.
  • Populated github labels field
  • Added test plan and verified test passes.
  • Verified that the PR passes existing CI.
  • Verified copyright is correct on all changed files.
  • Added succinct git squash message before merging ref.
  • All template sections are filled out.
  • Optional: Additional screenshots for behavior/output changes with before/after.

Commit Type:

Check the conventional commit type
box here and add the label to the github PR.

  • build
  • ci
  • docs
  • feat
  • fix
  • perf
  • refactor
  • revert
  • style
  • test

Related PRs:

triton-inference-server/python_backend#260
triton-inference-server/python_backend#384

Where should the reviewer start?

Test plan:

  • CI Pipeline ID:

Caveats:

Background

Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)

  • closes GitHub issue: #xxx

@nv-kmcgill53 nv-kmcgill53 added PR: ci Changes to our CI configuration files and scripts PR: refactor A code change that neither fixes a bug nor adds a feature labels Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: ci Changes to our CI configuration files and scripts PR: refactor A code change that neither fixes a bug nor adds a feature
Development

Successfully merging this pull request may close these issues.

1 participant