Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: Update TRT release branch referenced in model gen file #7693

Open
wants to merge 1 commit into
base: r24.10
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion qa/common/gen_qa_model_repository
Original file line number Diff line number Diff line change
Expand Up @@ -512,7 +512,7 @@ chmod -R 777 $FORMATDESTDIR
python3 $SRCDIR/gen_qa_trt_data_dependent_shape.py --models_dir=$DATADEPENDENTDIR
chmod -R 777 $DATADEPENDENTDIR
# Make shared library for custom Hardmax plugin.
(git clone -b release/10.0 https://github.com/NVIDIA/TensorRT.git && \
(git clone -b release/10.5 https://github.com/NVIDIA/TensorRT.git && \
Copy link
Contributor

@mc-nv mc-nv Oct 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This value is hardcoded and may bother us on next release, I would suggest following:

(git clone -b release/$(echo ${TRT_VERSION} | cut -d . -f -2) https://github.com/NVIDIA/TensorRT.git && \

Sure it's not a very flexible solution, but at least it will give us some time to stay away of changing it each release.

cd /workspace/TensorRT/samples/python/onnx_custom_plugin && rm -rf build && mkdir build && \
cd build && cmake .. && make -j && cp libcustomHardmaxPlugin.so $PLGDESTDIR/.)
LD_PRELOAD=$PLGDESTDIR/libcustomHardmaxPlugin.so python3 $SRCDIR/gen_qa_trt_plugin_models.py --models_dir=$PLGDESTDIR
Expand Down
Loading