Skip to content

Commit

Permalink
remove copy-frameworks build phase
Browse files Browse the repository at this point in the history
The copy-frameworks build phase embeds the Alamofire and ObjectMapper frameworks within the AlamofireObjectMapper framework - while the configuration works at runtime, it isn't efficient and more importantly, fails App Store submission with errors:
  ERROR ITMS-90205: contains disallowed nested bundles
  ERROR ITMS-90206: contains disallowed file 'Frameworks'

A host application needs to link against and copy the Alamofire and ObjectMapper frameworks anyways, so in addition to passing App Store submission, this change will also reclaim the 5.5 MB the embedded frameworks would have taken.
  • Loading branch information
Jean-Pierre Mouilleseaux committed Jun 10, 2015
1 parent 45a0c14 commit 20956b3
Showing 1 changed file with 0 additions and 19 deletions.
19 changes: 0 additions & 19 deletions AlamofireObjectMapper.xcodeproj/project.pbxproj
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,6 @@
6AB2A00C1AF26C36001EBB20 /* Sources */,
6AB2A00D1AF26C36001EBB20 /* Frameworks */,
6AB2A00E1AF26C36001EBB20 /* Headers */,
6A905E411B067F8100884083 /* ShellScript */,
);
buildRules = (
);
Expand Down Expand Up @@ -322,24 +321,6 @@
};
/* End PBXResourcesBuildPhase section */

/* Begin PBXShellScriptBuildPhase section */
6A905E411B067F8100884083 /* ShellScript */ = {
isa = PBXShellScriptBuildPhase;
buildActionMask = 2147483647;
files = (
);
inputPaths = (
"$(SRCROOT)/Carthage/Build/iOS/Alamofire.framework",
"$(SRCROOT)/Carthage/Build/iOS/ObjectMapper.framework",
);
outputPaths = (
);
runOnlyForDeploymentPostprocessing = 0;
shellPath = /bin/sh;
shellScript = "/usr/local/bin/carthage copy-frameworks";
};
/* End PBXShellScriptBuildPhase section */

/* Begin PBXSourcesBuildPhase section */
6AB2A00C1AF26C36001EBB20 /* Sources */ = {
isa = PBXSourcesBuildPhase;
Expand Down

0 comments on commit 20956b3

Please sign in to comment.