Add SSE-C option on native-filesystem security mapping #24566
Merged
+251
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anusudarsan
requested review from
marcinsbd and
wendigo
and removed request for
ssheikin
findinpath
reviewed
Dec 24, 2024
findinpath
reviewed
Dec 24, 2024
anusudarsan
force-pushed
the
anu/sse-c-native-fs-security-mapping
branch
from
33d2e81 to
be26d6d
Compare
...launcher/src/main/java/io/trino/tests/product/launcher/env/configs/ConfigDynamicCatalog.java
Outdated
Show resolved
Hide resolved
|
|
||
| // selected Customer key must match default or be allowed | ||
| if (!selected.equals(mapping.customerKey().orElse(null)) && | ||
| !mapping.allowedCustomerKeys().contains(selected) && |
There was a problem hiding this comment.
We're missing docs that would explain the relationship between customerKey and allowedCustomerKeys. customerKey is optional, but if users only set customerKey without any allowedCustomerKeys, this will always silently fail. Maybe we should throw an exception in this case?
There was a problem hiding this comment.
added a check for sseCustomerKey().isPresent() and allowedSseCustomerKeys().isEmpty()
There was a problem hiding this comment.
Thanks! But we're still missing docs that would describe it. KMS is well documented.
wendigo
reviewed
Dec 30, 2024
lib/trino-filesystem-s3/src/main/java/io/trino/filesystem/s3/S3Context.java
Outdated
Show resolved
Hide resolved
wendigo
reviewed
Dec 30, 2024
lib/trino-filesystem-s3/src/main/java/io/trino/filesystem/s3/S3FileSystemLoader.java
Outdated
Show resolved
Hide resolved
wendigo
reviewed
Dec 30, 2024
lib/trino-filesystem-s3/src/main/java/io/trino/filesystem/s3/S3SecurityMapping.java
Outdated
Show resolved
Hide resolved
wendigo
reviewed
Dec 30, 2024
lib/trino-filesystem-s3/src/main/java/io/trino/filesystem/s3/S3SecurityMapping.java
Outdated
Show resolved
Hide resolved
wendigo
reviewed
Dec 30, 2024
lib/trino-filesystem-s3/src/main/java/io/trino/filesystem/s3/S3SecurityMapping.java
Outdated
Show resolved
Hide resolved
wendigo
reviewed
Dec 30, 2024
lib/trino-filesystem-s3/src/main/java/io/trino/filesystem/s3/S3SecurityMappingConfig.java
Outdated
Show resolved
Hide resolved
wendigo
reviewed
Dec 30, 2024
lib/trino-filesystem-s3/src/main/java/io/trino/filesystem/s3/S3SecurityMappingProvider.java
Outdated
Show resolved
Hide resolved
wendigo
reviewed
Dec 30, 2024
lib/trino-filesystem-s3/src/main/java/io/trino/filesystem/s3/S3SecurityMappingProvider.java
Outdated
Show resolved
Hide resolved
wendigo
reviewed
Dec 30, 2024
lib/trino-filesystem-s3/src/main/java/io/trino/filesystem/s3/S3SecurityMappingProvider.java
Outdated
Show resolved
Hide resolved
wendigo
reviewed
Dec 30, 2024
lib/trino-filesystem-s3/src/main/java/io/trino/filesystem/s3/S3SecurityMappingProvider.java
Outdated
Show resolved
Hide resolved
wendigo
reviewed
Dec 30, 2024
lib/trino-filesystem-s3/src/main/java/io/trino/filesystem/s3/S3SecurityMappingProvider.java
Outdated
Show resolved
Hide resolved
wendigo
reviewed
Dec 30, 2024
anusudarsan
force-pushed
the
anu/sse-c-native-fs-security-mapping
branch
2 times, most recently
from
d218fbc to
a83052b
Compare
marcinsbd
reviewed
Dec 31, 2024
lib/trino-filesystem-s3/src/main/java/io/trino/filesystem/s3/S3SecurityMapping.java
Outdated
Show resolved
Hide resolved
lib/trino-filesystem-s3/src/main/java/io/trino/filesystem/s3/S3SecurityMapping.java
Outdated
Show resolved
Hide resolved
lib/trino-filesystem-s3/src/main/java/io/trino/filesystem/s3/S3SecurityMappingProvider.java
Outdated
Show resolved
Hide resolved
wendigo
force-pushed
the
anu/sse-c-native-fs-security-mapping
branch
from
a83052b to
686d724
Compare
wendigo
approved these changes
Dec 31, 2024
wendigo
force-pushed
the
anu/sse-c-native-fs-security-mapping
branch
from
686d724 to
d33d19b
Compare
|
@anusudarsan I think that we can merge it if the docs are fine (or follow up with the docs before the next release) |
anusudarsan
force-pushed
the
anu/sse-c-native-fs-security-mapping
branch
from
d33d19b to
14f0f04
Compare
|
pushed one more doc update |
nineinchnick
approved these changes
Dec 31, 2024
marcinsbd
approved these changes
Jan 2, 2025
|
I assume this needs a release notes entry .. suggestions @anusudarsan and @wendigo ? |
|
Add support for SSE-C in S3 security mapping |
|
Added |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Additional context and related issues
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: