Improve connector SQL support sections #24523
Open
+275
−166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mosabua
commented
Dec 18, 2024
docs/src/main/sphinx/connector/non-transactional-merge.fragment
Outdated
Show resolved
Hide resolved
chenjian2664
approved these changes
Dec 19, 2024
There was a problem hiding this comment.
Thanks. I was also thought to do this, but forgot :)
Involve @kokosing
docs/src/main/sphinx/connector/non-transactional-merge.fragment
Outdated
Show resolved
Hide resolved
|
Phoenix Connector also supports non transactional merge @mosabua |
|
Ignite connector also needs to be updated |
mosabua
force-pushed
the
jdbcmerge
branch
3 times, most recently
from
c2b3e8d to
38b298e
Compare
mosabua
changed the title
mosabua
force-pushed
the
jdbcmerge
branch
2 times, most recently
from
af58a05 to
3ff3d0f
Compare
mosabua
changed the title
mosabua
force-pushed
the
jdbcmerge
branch
2 times, most recently
from
8123393 to
56b19c2
Compare
|
I think this is good to go now .. Updated all JDBC connectors and made them more consistent. Also added the Ignite and Phoenix merge .. all in clean separate commits .. I think we should work towards merge and I can revisit the whole stuff more for other connectors. |
As applicable for PostgreSQL connector for now. Also extract into a fragment so it can be reused in other connectors.
- No content changes but... - Consistent wording _ Markdown link syntax - Move related configs to SQL support section - Improve list and rejig as small local ToC, add links
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Additional context and related issues
Follow up to #23034 and related PRs.
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.