Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update supported clickhouse versions #24515

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ssheikin
Copy link
Contributor

@ssheikin ssheikin commented Dec 18, 2024

Description

Additional context and related issues

Release notes

( ) This is not user-visible or is docs only, and no release notes are required.
() Release notes are required. Please propose a release note for me.
(x) Release notes are required, with the following suggested text:

## Section
* Update supported clickhouse versions. ({issue}`24515`)

@cla-bot cla-bot bot added the cla-signed label Dec 18, 2024
@ssheikin ssheikin requested a review from Praveen2112 December 18, 2024 11:39
@ssheikin ssheikin force-pushed the ssheikin/26/trino/clickhouse-versions branch 3 times, most recently from 351f040 to 4524471 Compare December 18, 2024 12:41
@mosabua
Copy link
Member

mosabua commented Dec 18, 2024

Should update requirements section in docs probably

@ssheikin
Copy link
Contributor Author

ssheikin commented Dec 20, 2024

Newer images facing
ClickHouse/clickhouse-java#1245
ClickHouse/clickhouse-java#1584
@mosabua I guess we have to mention it in docs too
externalDatabase=false has to be added to connection-url because otherwise Schema listing fetch is extremely slow on Clickhouse-server 24.3+

@ssheikin ssheikin added the needs-docs This pull request requires changes to the documentation label Dec 20, 2024
@ssheikin ssheikin force-pushed the ssheikin/26/trino/clickhouse-versions branch 2 times, most recently from 844e08f to 854382b Compare December 20, 2024 16:56
@ssheikin ssheikin requested a review from ebyhr December 20, 2024 17:13
@ssheikin ssheikin force-pushed the ssheikin/26/trino/clickhouse-versions branch 2 times, most recently from 21d9aac to 6f3ed92 Compare December 30, 2024 10:48
@github-actions github-actions bot added the docs label Dec 30, 2024
@ssheikin ssheikin force-pushed the ssheikin/26/trino/clickhouse-versions branch from 6f3ed92 to 9186ab9 Compare December 30, 2024 12:22
plugin/trino-clickhouse/pom.xml Outdated Show resolved Hide resolved
plugin/trino-clickhouse/pom.xml Show resolved Hide resolved
@ssheikin ssheikin force-pushed the ssheikin/26/trino/clickhouse-versions branch from 9186ab9 to 22958f0 Compare December 30, 2024 12:27
@ssheikin ssheikin force-pushed the ssheikin/26/trino/clickhouse-versions branch from 22958f0 to e605a05 Compare December 30, 2024 12:36
Copy link
Member

@Praveen2112 Praveen2112 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to capture the JDBC client update in the same PR/commit ?

/**
* <a href="https://clickhouse.com/docs/en/faq/operations/production#how-to-choose-between-clickhouse-releases">How to Choose Between ClickHouse Releases?</a>
* <p>
* stable is the kind of package we recommend by default.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

**stable**

* stable is the kind of package we recommend by default.
* They are released roughly monthly (and thus provide new features with reasonable delay)
* and three latest stable releases are supported in terms of diagnostics and backporting of bugfixes.
* lts are released twice a year and are supported for a year after their initial release.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New line so to differentiate between **stable**
**lts**

@@ -462,7 +462,7 @@
<dependency>
<groupId>com.clickhouse</groupId>
<artifactId>clickhouse-jdbc</artifactId>
<version>0.6.3</version>
<version>0.7.1-patch1</version>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we wait for their official release or is patch1 is their official release ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change might allow us to rename the commit message and release-notes as we are updating the client as well

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like patch suffix is an official way in their release process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed docs needs-docs This pull request requires changes to the documentation
Development

Successfully merging this pull request may close these issues.

3 participants