-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update supported clickhouse versions #24515
base: master
Are you sure you want to change the base?
Update supported clickhouse versions #24515
Conversation
351f040
to
4524471
Compare
Should update requirements section in docs probably |
Newer images facing |
844e08f
to
854382b
Compare
...n/trino-clickhouse/src/test/java/io/trino/plugin/clickhouse/TestClickHouseConnectorTest.java
Outdated
Show resolved
Hide resolved
21d9aac
to
6f3ed92
Compare
...n/trino-clickhouse/src/test/java/io/trino/plugin/clickhouse/TestClickHouseConnectorTest.java
Outdated
Show resolved
Hide resolved
plugin/trino-clickhouse/src/test/java/io/trino/plugin/clickhouse/TestingClickHouseServer.java
Outdated
Show resolved
Hide resolved
plugin/trino-clickhouse/src/test/java/io/trino/plugin/clickhouse/TestingClickHouseServer.java
Outdated
Show resolved
Hide resolved
plugin/trino-clickhouse/src/test/java/io/trino/plugin/clickhouse/TestingClickHouseServer.java
Show resolved
Hide resolved
6f3ed92
to
9186ab9
Compare
9186ab9
to
22958f0
Compare
22958f0
to
e605a05
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to capture the JDBC client update in the same PR/commit ?
/** | ||
* <a href="https://clickhouse.com/docs/en/faq/operations/production#how-to-choose-between-clickhouse-releases">How to Choose Between ClickHouse Releases?</a> | ||
* <p> | ||
* stable is the kind of package we recommend by default. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
**stable**
* stable is the kind of package we recommend by default. | ||
* They are released roughly monthly (and thus provide new features with reasonable delay) | ||
* and three latest stable releases are supported in terms of diagnostics and backporting of bugfixes. | ||
* lts are released twice a year and are supported for a year after their initial release. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New line so to differentiate between **stable**
**lts**
@@ -462,7 +462,7 @@ | |||
<dependency> | |||
<groupId>com.clickhouse</groupId> | |||
<artifactId>clickhouse-jdbc</artifactId> | |||
<version>0.6.3</version> | |||
<version>0.7.1-patch1</version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we wait for their official release or is patch1
is their official release ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change might allow us to rename the commit message and release-notes as we are updating the client as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like patch
suffix is an official way in their release process.
Description
Additional context and related issues
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
() Release notes are required. Please propose a release note for me.
(x) Release notes are required, with the following suggested text: