-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update and expand UDF docs #24441
Merged
Merged
Update and expand UDF docs #24441
+918
−627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mosabua
force-pushed
the
udf
branch
2 times, most recently
from
December 11, 2024 00:31
6f84b89
to
64e98f0
Compare
mosabua
force-pushed
the
udf
branch
4 times, most recently
from
December 12, 2024 23:23
5840422
to
c2cceef
Compare
mosabua
force-pushed
the
udf
branch
3 times, most recently
from
December 13, 2024 22:36
3616d50
to
e587384
Compare
electrum
reviewed
Dec 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
electrum
approved these changes
Dec 16, 2024
Move them in appropriate folders for user-defined functions and SQL user-defined functions. Update all references so that the docs build process fully works.
And generally introduce user-defined functions (UDF) as a term.
Into the separate page, and adjust the generic content to be suitable for any UDF language.
Into the separate page, and adjust the generic content to be suitable for any UDF language.
mosabua
force-pushed
the
udf
branch
3 times, most recently
from
December 16, 2024 17:56
c92941f
to
f7aeb5e
Compare
This was referenced Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Main updates are to rebrand from "SQL routines" to "User-defined functions (UDFs)" and "SQL user-defined functions", rejig all the content so it is an appropriate base, and then add "Python user-defined functions".
More details in the commit messages since there is a lot happening.
Note to reviewers: Review per commit and potentially build locally to see rendered output. When rewording paragraphs and such wrapping was also always fixed/updated.
Additional context and related issues
#24378
Release notes
Note sure yet .. we might want to add a release note even though this should not break anything or have any user facing context itself.. just so its clear that we are rebranding.
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: