Fix storage table data clean up while dropping iceberg materialized view #24397
+133
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anusudarsan
force-pushed
the
anu/fix-data-drop-iceberg-mv
branch
from
63aa304 to
bed3be2
Compare
alexjo2144
approved these changes
Dec 9, 2024
ebyhr
reviewed
Dec 9, 2024
...st/java/io/trino/plugin/iceberg/catalog/hms/TestTrinoLegacyHiveCatalogWithHiveMetastore.java
Outdated
Show resolved
Hide resolved
...st/java/io/trino/plugin/iceberg/catalog/hms/TestTrinoLegacyHiveCatalogWithHiveMetastore.java
Outdated
Show resolved
Hide resolved
...src/test/java/io/trino/plugin/iceberg/catalog/hms/TestTrinoHiveCatalogWithHiveMetastore.java
Outdated
Show resolved
Hide resolved
...src/test/java/io/trino/plugin/iceberg/catalog/hms/TestTrinoHiveCatalogWithHiveMetastore.java
Outdated
Show resolved
Hide resolved
...src/test/java/io/trino/plugin/iceberg/catalog/hms/TestTrinoHiveCatalogWithHiveMetastore.java
Outdated
Show resolved
Hide resolved
This is for cleaning up data files in legacy mode i.e iceberg.materialized-views.hide-storage-table is set to false. Delegating the drop table to metastore does not clean up the data files since for HMS, the iceberg table is registered as an "external" table. So to fix this instead of delegating to metastore, have the connector do the drop of the table and data files associated with it.
anusudarsan
force-pushed
the
anu/fix-data-drop-iceberg-mv
branch
from
bed3be2 to
c7a2d54
Compare
ebyhr
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is for cleaning up data files in legacy mode i.e iceberg.materialized-views.hide-storage-table is set to false. Delegating the drop table to metastore does not clean up the data files since for HMS, the iceberg table is registered as an "external" table. So to fix this instead of delegating to metastore, have the connector do the drop of the table and data files associated with it.
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.