Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert suppressed logging #24365

Merged
merged 1 commit into from
Dec 4, 2024
Merged

Conversation

wendigo
Copy link
Contributor

@wendigo wendigo commented Dec 4, 2024

This actually hides an issue with the tracing filter fixed in airlift/airlift#1333

Description

Additional context and related issues

Release notes

( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text:

## Section
* Fix some things. ({issue}`issuenumber`)

@cla-bot cla-bot bot added the cla-signed label Dec 4, 2024
@wendigo wendigo requested a review from losipiuk December 4, 2024 12:41
This actually hides an issue with the tracing filter fixed in airlift/airlift#1333
@wendigo wendigo force-pushed the serafin/revert-suppressed-logging branch from 00f43f5 to d181eb1 Compare December 4, 2024 12:44
Copy link
Member

@losipiuk losipiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IDK.
Who introduce that. What was the motivation.

@wendigo
Copy link
Contributor Author

wendigo commented Dec 4, 2024

@losipiuk I did ;)

@wendigo wendigo merged commit 28d6c1f into master Dec 4, 2024
103 of 104 checks passed
@wendigo wendigo deleted the serafin/revert-suppressed-logging branch December 4, 2024 13:57
@github-actions github-actions bot added this to the 467 milestone Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants