Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Support For Configurable Updatable Table Properties per Iceberg Catalog Type #23905

Conversation

srnand
Copy link
Member

@srnand srnand commented Oct 24, 2024

Description

  • For the use cases involving custom table properties per Iceberg catalog type, this update allows the specification of which properties are updatable for a given catalog.
  • Added the existing default behavior in the TrinoCatalog Iface so as to not break existing dependencies.

Release notes

(x) This is not user-visible or is docs only, and no release notes are required.

@cla-bot cla-bot bot added the cla-signed label Oct 24, 2024
@github-actions github-actions bot added the iceberg Iceberg connector label Oct 24, 2024
@@ -196,4 +197,9 @@ void createMaterializedView(
void updateColumnComment(ConnectorSession session, SchemaTableName schemaTableName, ColumnIdentity columnIdentity, Optional<String> comment);

Optional<CatalogSchemaTableName> redirectTable(ConnectorSession session, SchemaTableName tableName, String hiveCatalogName);

default Set<String> getUpdatableTableProperties()
Copy link
Member

@ebyhr ebyhr Oct 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this an extension point for your fork? Why not do that in your repository if so?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was a simple change that could be contributed back to OSS hence opened up for here.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ebyhr and then I'll backport this change if this goes through.
but even though I am a member of the trino community and I did the CLA thing, not sure why it says i am not authorized 🤔

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First of all, I am not convinced with this change. We usually deny fork-specific changes.

What do you mean > "i am not authorized"?

Copy link

github-actions bot commented Dec 5, 2024

This pull request has gone a while without any activity. Tagging for triage help: @mosabua

@github-actions github-actions bot added the stale label Dec 5, 2024
@ebyhr
Copy link
Member

ebyhr commented Dec 10, 2024

Let me close as a stale PR.

@ebyhr ebyhr closed this Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants