-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecated access control functions #23244
Remove deprecated access control functions #23244
Conversation
We should mention SPI changes in release notes. Could you update the PR description? |
You're right, I'll fix. On the other hand, I was expecting revapi to complain - does it ignore changes to deprecated methods? |
This pull request has gone a while without any activity. Tagging the Trino developer relations team: @bitsondatadev @colebow @mosabua |
Closing this pull request, as it has been stale for six weeks. Feel free to re-open at any time. |
Hey @dain I am reopening this.. I think we should still do this clean up. Thoughts? |
If necessary.. please rebase @ksobolew |
Also added stale-ignore label |
It was deprecated in 445 when a replacement method was added; I guess 10 versions is long enough for a transition period.
It was deprecated in 445 when a replacement method was added; I guess 10 versions is long enough for a transition period.
4ffc79c
to
8b22aeb
Compare
@wendigo there's one failing test:
It's clearly unrelated. |
Description
They were deprecated in 445 when replacement methods were added; I guess 10 versions is long enough for a transition period.
Additional context and related issues
Related PR: #21374
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
(x) Release notes are required, with the following suggested text: