Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated access control functions #23244

Conversation

ksobolew
Copy link
Contributor

@ksobolew ksobolew commented Sep 3, 2024

Description

They were deprecated in 445 when replacement methods were added; I guess 10 versions is long enough for a transition period.

Additional context and related issues

Related PR: #21374

Release notes

( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
(x) Release notes are required, with the following suggested text:

# SPI (Breaking Change)
* Removed deprecated variants of `checkCanExecuteQuery` and `checkCanSetSystemSessionProperty` that do not take `QueryId` parameter from `SystemAccessControl`. ({issue}`23244`)

@cla-bot cla-bot bot added the cla-signed label Sep 3, 2024
@hashhar hashhar requested a review from dain September 3, 2024 10:02
@ebyhr
Copy link
Member

ebyhr commented Sep 3, 2024

(x) This is not user-visible or is docs only, and no release notes are required.

We should mention SPI changes in release notes. Could you update the PR description?

@ksobolew
Copy link
Contributor Author

ksobolew commented Sep 3, 2024

We should mention SPI changes in release notes. Could you update the PR description?

You're right, I'll fix. On the other hand, I was expecting revapi to complain - does it ignore changes to deprecated methods?

Copy link

This pull request has gone a while without any activity. Tagging the Trino developer relations team: @bitsondatadev @colebow @mosabua

@github-actions github-actions bot added the stale label Sep 24, 2024
Copy link

Closing this pull request, as it has been stale for six weeks. Feel free to re-open at any time.

@github-actions github-actions bot closed this Oct 16, 2024
@mosabua mosabua reopened this Oct 16, 2024
@mosabua
Copy link
Member

mosabua commented Oct 16, 2024

Hey @dain I am reopening this.. I think we should still do this clean up. Thoughts?

@mosabua mosabua added stale-ignore Use this label on PRs that should be ignored by the stale bot so they are not flagged or closed. and removed stale labels Oct 16, 2024
@mosabua
Copy link
Member

mosabua commented Oct 16, 2024

If necessary.. please rebase @ksobolew

@mosabua
Copy link
Member

mosabua commented Oct 16, 2024

Also added stale-ignore label

It was deprecated in 445 when a replacement method was added; I guess 10
versions is long enough for a transition period.
It was deprecated in 445 when a replacement method was added; I guess 10
versions is long enough for a transition period.
@ksobolew ksobolew force-pushed the kudi/remove-deprecated-access-control-functions branch from 4ffc79c to 8b22aeb Compare November 8, 2024 11:02
@ksobolew
Copy link
Contributor Author

ksobolew commented Nov 8, 2024

@wendigo there's one failing test:

Error:  Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 205.5 s <<< FAILURE! -- in io.trino.filesystem.alluxio.TestAlluxioFileSystem
Error:  io.trino.filesystem.alluxio.TestAlluxioFileSystem -- Time elapsed: 205.5 s <<< ERROR!
java.util.concurrent.ExecutionException: org.testcontainers.containers.ContainerLaunchException: Container startup failed for image alluxio/alluxio:2.9.5

It's clearly unrelated.

@wendigo wendigo merged commit 71a0b9d into trinodb:master Nov 8, 2024
91 of 92 checks passed
@ksobolew ksobolew deleted the kudi/remove-deprecated-access-control-functions branch November 8, 2024 12:09
@github-actions github-actions bot added this to the 465 milestone Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed stale-ignore Use this label on PRs that should be ignored by the stale bot so they are not flagged or closed.
Development

Successfully merging this pull request may close these issues.

5 participants