Properly finish stage on noMorePartitions signal #19855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
losipiuk
changed the title
Theoretically it is possible that all task partitions for a stage complete before we get noMorePartitions signal from SplitAssigner. In such case we should execute same finish routie as we do when last task partition completes and noMorePartitions is already set. This is cleanup, not a bugfix as currently no SplitAssigner (even though it is not guaranteed by interface) would seal all of the task partitions without returning noMorePartitions flag in the same AssignmentResult object.
losipiuk
force-pushed
the
lo/fix-no-more-partitions-fte
branch
from
066ae8e to
ec3eff6
Compare
findepi
approved these changes
Nov 22, 2023
sopel39
approved these changes
Nov 22, 2023
|
nit: is it worth having a test? |
It would be great. The problem is that so far we did not find any reasonable way of testing scheduer code at - other than running queries and seeing they work - but regarding corner cases like this one not really. Any suggestions are welcome |
Could we have some dummy "scenarios" that we use for testing scheduler and check if it behaves in expected way? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Theoretically it is possible that all task partitions for a stage
complete before we get noMorePartitions signal from SplitAssigner.
In such case we should execute same finish routie as we do when last
task partition completes and noMorePartitions is already set.
This is cleanup, not a bugfix as currently no SplitAssigner
(even though it is not guaranteed by interface) would seal
all of the task partitions without returning noMorePartitions flag in
the same AssignmentResult object.
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: