Unify and supplement short-circuiting in MetadataManager #19842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When concurrency is not involved, it is not needed and when it is involved, it doesn't provide more correctness. FWIW, the `system.jdbc.tables` doesn't have similar set unioning.
Prevent passing impossible names down to the connectors. E.g. prevents failures if a connector chooses to convert input to something that validates name is not impossible, like `SchemaTablePrefix`.
`listMaterializedViews` can return names already included in metastore's relation listing.
losipiuk
reviewed
Nov 21, 2023
| @@ -285,7 +284,7 @@ private void addTablesRecords(QualifiedTablePrefix prefix) | |||
| } | |||
| // TODO (https://github.com/trinodb/trino/issues/8207) define a type for materialized views | |||
|
|
|||
| for (SchemaTableName name : union(tables, views)) { | |||
| for (SchemaTableName name : tables) { | |||
There was a problem hiding this comment.
what was the reason for union in the first place?
There was a problem hiding this comment.
I don't know. The code dates back 2014 5a727b8. Maybe back then table listing didn't include views, or maybe the code author was simply confused about "list tables" means. I wouldn't be surprised either way, I've seen people being confused and connectors being implemented incorrectly (#11063). That's why i proposed renaming "list tables" to "list relations".
See #19832 (comment)
losipiuk
approved these changes
Nov 21, 2023
findepi
deleted the
findepi/unify-and-supplement-short-circuiting-in-metadatamanager-e741cd
branch
findepi
added
the
no-release-notes
|
yes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent passing impossible names down to the connectors.
E.g. prevents failures if a connector chooses to convert input to
something that validates name is not impossible, like
SchemaTablePrefix.