Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove storing TableSnapshot when multiple tables queried #19732

Merged
merged 1 commit into from
Nov 15, 2023

Conversation

pajaks
Copy link
Member

@pajaks pajaks commented Nov 14, 2023

Description

In order to reduce memory stress in DeltaLake by remove storing TableSnapshot.
It can be removed when query requests multiple tables and we know that this information will be not used anymore.

Additional context and related issues

Release notes

( x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text:

# Section
* Fix some things. ({issue}`issuenumber`)

@cla-bot cla-bot bot added the cla-signed label Nov 14, 2023
@github-actions github-actions bot added the delta-lake Delta Lake connector label Nov 14, 2023
@findepi
Copy link
Member

findepi commented Nov 14, 2023

Please change PR and commit title to sth like "Remove storing TableSnapshot during metadata queries".

otherwise lgtm

@pajaks pajaks force-pushed the pajaks/snapshot_loading_improvement branch from d7db06b to 9d7807a Compare November 14, 2023 13:43
@ebyhr ebyhr merged commit 848a2dd into trinodb:master Nov 15, 2023
23 checks passed
@github-actions github-actions bot added this to the 434 milestone Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed delta-lake Delta Lake connector
Development

Successfully merging this pull request may close these issues.

4 participants