Pushdown predicates fully in BigQuery connector #19699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebyhr
force-pushed
the
ebi/bigquery-filter-pushdown
branch
3 times, most recently
from
bb04138 to
3b23202
Compare
ebyhr
commented
Nov 11, 2023
Comment on lines
+145
to
+147
| tableConstraint.getDomains().ifPresent(domains -> domains.keySet().stream() | ||
| .map(column -> ((BigQueryColumnHandle) column).getName()) | ||
| .forEach(projectedColumnsNames::add)); |
There was a problem hiding this comment.
Otherwise, TestBigQueryAvroConnectorTest.testEmptyProjectionView throws the following error:
io.grpc.StatusRuntimeException: INVALID_ARGUMENT: request failed: Query error: Unrecognized name: regionkey at [1:105]
hashhar
reviewed
Nov 13, 2023
ebyhr
force-pushed
the
ebi/bigquery-filter-pushdown
branch
from
3b23202 to
cfb86d5
Compare
We don't have the test as far as I confirmed. Added |
ebyhr
force-pushed
the
ebi/bigquery-filter-pushdown
branch
2 times, most recently
from
0ef7d12 to
7c4999a
Compare
ebyhr
force-pushed
the
ebi/bigquery-filter-pushdown
branch
from
7c4999a to
dc5a296
Compare
|
Rebased on master to resolve conflicts. |
hashhar
reviewed
Nov 16, 2023
| @Test | ||
| public void testPredicatePushdown() | ||
| { | ||
| testPredicatePushdown("true", "true", true); |
There was a problem hiding this comment.
i was thinking of tests which had two predicates, one which could be pushed down and the other which gets retained.
This one is useful too since it was missing entirely.
There was a problem hiding this comment.
Let's improve the test coverage in follow-up.
hashhar
approved these changes
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Pushdown predicates fully in BigQuery connector
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.