Fix blob creation in trino file system tests #19678
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: if the root location is not empty then |
elonazoulay
force-pushed
the
fix_ci_gcs_tests
branch
from
6e33b90 to
9e95aec
Compare
|
I can also add the |
elonazoulay
commented
Nov 8, 2023
| String bucket = RemoteStorageHelper.generateBucketName(); | ||
| storage.create(BucketInfo.of(bucket)); | ||
| this.rootLocation = Location.of("gs://%s/".formatted(bucket)); | ||
| if (storage.get(bucket) == null) { |
There was a problem hiding this comment.
Should the bucket be created if it does not exist?
elonazoulay
force-pushed
the
fix_ci_gcs_tests
branch
3 times, most recently
from
41b012e to
08595cc
Compare
|
/test-with-secrets sha=08595ccc84d539eadba1fe012114f25181b79e6c |
|
The CI workflow run with tests that require additional secrets finished as failure: https://github.com/trinodb/trino/actions/runs/6807141951 |
elonazoulay
force-pushed
the
fix_ci_gcs_tests
branch
from
08595cc to
0ad8a4d
Compare
electrum
requested changes
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Additional context and related issues
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: