Switch required Java version to 21.0.1 #19382
Conversation
wendigo
force-pushed
the
serafin/jdk21-tests
branch
from
06c8755 to
21b4421
Compare
|
It seems that ppc64le image is missing for Temurin 21 :( |
wendigo
force-pushed
the
serafin/jdk21-tests
branch
2 times, most recently
from
a994e43 to
32b8153
Compare
|
I filed an issue: adoptium/containers#435 |
|
Looks like they are still working on publishing a container for that architecture. |
wendigo
force-pushed
the
serafin/jdk21-tests
branch
from
32b8153 to
e731e41
Compare
wendigo
force-pushed
the
serafin/jdk21-tests
branch
from
e731e41 to
fd7916c
Compare
wendigo
changed the title
wendigo
force-pushed
the
serafin/jdk21-tests
branch
from
fd7916c to
b9e17d2
Compare
There was a problem hiding this comment.
Just a few minor nits, but essentially good to go.
I am not sure about how much longer we want to monitor with 21 before we switch. If we need more input and wait longer I can write a blog post to call for input.
However personally I think we should just gather our own knowledge around using 21 and assess .. and probably merge. If we find issues we fix them in next releases. It seems unlikely that a JDK issue will cause issues that prevent Trino from being usable and causes us to back this out.
wendigo
force-pushed
the
serafin/jdk21-tests
branch
from
b9e17d2 to
91e7843
Compare
|
On top of #19551 |
wendigo
force-pushed
the
serafin/jdk21-tests
branch
from
91e7843 to
80a8c24
Compare
|
Had a chat with @dain and @martint and we all think we need to split this up into a PR that leave the tarball and requirements alone but updates the docker container. Dain and Martin and @electrum should confirm details before you proceed though. I will work on a blog post to ask for testing and input next week. |
wendigo
force-pushed
the
serafin/jdk21-tests
branch
from
80a8c24 to
aeea428
Compare
Replaces #17520