Clarify UPDATE statement support for JDBC connectors #19341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blvckcoffee
requested review from
mosabua,
jhlodin,
vlad-lyutenko and
colebow
mosabua
requested changes
Oct 10, 2023
There was a problem hiding this comment.
Mostly okay but still needs clarification and confirmation from @vlad-lyutenko
| UPDATE table SET col1 = 1 WHERE col3 = 1 AND col2 = 3 | ||
| ``` | ||
|
|
||
| All column values of a table row can not be updated simultaneously. The |
There was a problem hiding this comment.
All?
You mean not more than one?
There was a problem hiding this comment.
it could be more then one but not all columns :
like if have 6 columns in table we can update 5, 4, ... simultaneously, but not 6
There was a problem hiding this comment.
I meant all. You can update multiple columns simultaneously. The distinction is that you can't update every column in the table simultaneously.
hashhar
reviewed
Oct 11, 2023
blvckcoffee
force-pushed
the
jj/clarify-update-support
branch
from
5c94005 to
1a1c120
Compare
mosabua
reviewed
Oct 11, 2023
mosabua
reviewed
Oct 11, 2023
mosabua
reviewed
Oct 11, 2023
|
Still more clarification needed @vlad-lyutenko and @blvckcoffee ... |
blvckcoffee
force-pushed
the
jj/clarify-update-support
branch
from
1a1c120 to
c3b27d3
Compare
mosabua
requested changes
Oct 12, 2023
blvckcoffee
force-pushed
the
jj/clarify-update-support
branch
from
c3b27d3 to
63829b1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
UPDATEstatements to docs pages for several JDBC connectors. This documentation is incomplete and more specific detail ofUPDATEsupport is required. This PR creates a fragment detailingUPDATEsupport limitations.Additional context and related issues
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: