Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve SQL language landing pages #19167

Merged
merged 1 commit into from
Oct 20, 2023
Merged

Conversation

mosabua
Copy link
Member

@mosabua mosabua commented Sep 26, 2023

Description

As requested and discussed with @electrum and @martint

Release notes

(x) This is not user-visible or is docs only, and no release notes are required.

@mosabua mosabua requested review from electrum and martint September 26, 2023 17:58
@cla-bot cla-bot bot added the cla-signed label Sep 26, 2023
@mosabua mosabua changed the title Move SQL language docs [WIP] Move SQL language docs Sep 26, 2023
@Akanksha-kedia
Copy link

@mosabua hello, just wanted to understand the requirement of this pr.

@mosabua mosabua changed the title [WIP] Move SQL language docs Improve SQL language landing pages Oct 11, 2023
@mosabua
Copy link
Member Author

mosabua commented Oct 11, 2023

@mosabua hello, just wanted to understand the requirement of this pr.

What do you mean @Akanksha-kedia .. we just want to improve some of the wording and structure of the SQL-related documentation. Also in preparation for the incoming docs for SQL routines (#18854)

* And table of content moves
```{toctree}
:hidden:

sql/pattern-recognition-in-window
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we should also hide MATCH-RECOGNIZE from the toc following the logic that all statmenents in the nav are top level executable

@mosabua mosabua merged commit 0a8865b into trinodb:master Oct 20, 2023
5 checks passed
@mosabua mosabua deleted the sql-moves branch October 20, 2023 19:30
@github-actions github-actions bot added this to the 430 milestone Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants