Add support for timezone parameter to JDBC driver #19102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hashhar
force-pushed
the
hashhar/timezone-jdbc
branch
from
82efc36 to
2b9493b
Compare
hashhar
requested review from
electrum,
wendigo,
findepi,
nineinchnick and
aalbu
client/trino-client/src/main/java/io/trino/client/uri/TrinoUri.java
Outdated
Show resolved
Hide resolved
hashhar
force-pushed
the
hashhar/timezone-jdbc
branch
from
2b9493b to
ec21724
Compare
hashhar
commented
Sep 20, 2023
client/trino-jdbc/src/test/java/io/trino/jdbc/TestTrinoDriverUri.java
Outdated
Show resolved
Hide resolved
aalbu
reviewed
Sep 21, 2023
client/trino-client/src/main/java/io/trino/client/uri/ConnectionProperties.java
Outdated
Show resolved
Hide resolved
hashhar
force-pushed
the
hashhar/timezone-jdbc
branch
from
ec21724 to
009d6ab
Compare
wendigo
approved these changes
Oct 6, 2023
|
@hashhar please squash so we can merge it |
electrum
approved these changes
Oct 8, 2023
client/trino-client/src/main/java/io/trino/client/uri/TrinoUri.java
Outdated
Show resolved
Hide resolved
client/trino-client/src/main/java/io/trino/client/uri/ConnectionProperties.java
Outdated
Show resolved
Hide resolved
hashhar
force-pushed
the
hashhar/timezone-jdbc
branch
from
891f212 to
4fdfa52
Compare
hashhar
force-pushed
the
hashhar/timezone-jdbc
branch
from
4fdfa52 to
8db9844
Compare
|
@electrum PTAL, addressed your comments. Thanks for comment about the exception handling, makes it much simpler. |
nineinchnick
approved these changes
Oct 16, 2023
wendigo
approved these changes
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add support for timezone parameter to JDBC driver
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
(x) Release notes are required, with the following suggested text: