-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Firebolt connector #18526
Add Firebolt connector #18526
Conversation
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you also add documentation?
Had a first glimpse only.
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
Added documentation in the Connectors section. Let me know if I need to modify any other docs. |
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
@trinodb/maintainers Could I get some eyes on this PR please? |
@ptiurin Does Firebolt provide the dockerized image? If not, can your company offer a free account for running CI? |
There's no dockerised image for Firebolt. I've started a process of provisioning a partner account for you, will get back once that's done. What's the best way of sharing the credentials for it with you? |
Replied in Slack DM. |
This pull request has gone a while without any activity. Tagging the Trino developer relations team: @bitsondatadev @colebow @mosabua |
This pull request has gone a while without any activity. Tagging the Trino developer relations team: @bitsondatadev @colebow @mosabua |
Sorry for the silence here, I currently have no capacity to work on this change. Feel free to close it if you have to and I will open a new off the latest master when there's interest. |
Description
Adding support for Firebolt in Trino. Firebolt uses a JDBC driver to connect to the database with SQL syntax close to PostgreSQL. Therefore, this connector was largely based on Postgres.
Additional context and related issues
Firebolt is a cloud data warehouse. Relevant information on SQL syntax can be found in docs.
Notably, data types and sql functions.
Release notes
( ) This is not user-visible or docs only and no release notes are required.
(X) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text: