Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Firebolt connector #18526

Closed
wants to merge 4 commits into from
Closed

Conversation

ptiurin
Copy link
Member

@ptiurin ptiurin commented Aug 3, 2023

Description

Adding support for Firebolt in Trino. Firebolt uses a JDBC driver to connect to the database with SQL syntax close to PostgreSQL. Therefore, this connector was largely based on Postgres.

Additional context and related issues

Firebolt is a cloud data warehouse. Relevant information on SQL syntax can be found in docs.
Notably, data types and sql functions.

Release notes

( ) This is not user-visible or docs only and no release notes are required.
(X) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text:

@cla-bot
Copy link

cla-bot bot commented Aug 3, 2023

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@mosabua mosabua changed the title Adding Firebolt connector Add Firebolt connector Aug 3, 2023
Copy link
Member

@mosabua mosabua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also add documentation?

Had a first glimpse only.

plugin/trino-firebolt/pom.xml Outdated Show resolved Hide resolved
plugin/trino-firebolt/pom.xml Outdated Show resolved Hide resolved
@cla-bot
Copy link

cla-bot bot commented Aug 8, 2023

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@ptiurin
Copy link
Member Author

ptiurin commented Aug 8, 2023

Could you also add documentation?

Added documentation in the Connectors section. Let me know if I need to modify any other docs.

@github-actions github-actions bot added the docs label Aug 8, 2023
@cla-bot
Copy link

cla-bot bot commented Aug 10, 2023

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@cla-bot cla-bot bot added the cla-signed label Oct 9, 2023
@ptiurin ptiurin requested a review from mosabua October 9, 2023 14:04
@ptiurin
Copy link
Member Author

ptiurin commented Oct 17, 2023

@trinodb/maintainers Could I get some eyes on this PR please?

@ebyhr
Copy link
Member

ebyhr commented Oct 17, 2023

@ptiurin Does Firebolt provide the dockerized image? If not, can your company offer a free account for running CI?

@ptiurin
Copy link
Member Author

ptiurin commented Oct 18, 2023

@ptiurin Does Firebolt provide the dockerized image? If not, can your company offer a free account for running CI?

There's no dockerised image for Firebolt. I've started a process of provisioning a partner account for you, will get back once that's done. What's the best way of sharing the credentials for it with you?

@ebyhr
Copy link
Member

ebyhr commented Oct 19, 2023

Replied in Slack DM.

Copy link

This pull request has gone a while without any activity. Tagging the Trino developer relations team: @bitsondatadev @colebow @mosabua

@github-actions github-actions bot added the stale label Jan 11, 2024
@mosabua
Copy link
Member

mosabua commented Jan 11, 2024

@ebyhr @ptiurin let me know if I can help somehow

@github-actions github-actions bot removed the stale label Jan 12, 2024
Copy link

github-actions bot commented Feb 2, 2024

This pull request has gone a while without any activity. Tagging the Trino developer relations team: @bitsondatadev @colebow @mosabua

@github-actions github-actions bot added the stale label Feb 2, 2024
@ptiurin
Copy link
Member Author

ptiurin commented Feb 2, 2024

Sorry for the silence here, I currently have no capacity to work on this change. Feel free to close it if you have to and I will open a new off the latest master when there's interest.

@mosabua mosabua closed this Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants