Add missing test case to TestBlockAndPositionNullConvention #18463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
findepi
approved these changes
Jul 31, 2023
Not that I know of... These refactorings were huge, though, so there's a non-zero chance. |
OTOH, the test is called |
Looks like it got lost during the refactoring in commit 98c5243. Originally it used `null` for a generic object type, but perhaps a "real" object like row is better here. This was detected by the write-only object inspection in IDEA: the `hitBlockPositionObject` was reported as never read from.
ksobolew
force-pushed
the
kudi/write-only
branch
from
0a62fc6 to
99ca0ff
Compare
|
This pull request has gone a while without any activity. Tagging the Trino developer relations team: @bitsondatadev @colebow @mosabua |
|
This pull request has gone a while without any activity. Tagging the Trino developer relations team: @bitsondatadev @colebow @mosabua |
|
Thank you @findepi ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Looks like it got lost during the refactoring in commit 98c5243. Originally it used
nullfor a generic object type, but perhaps a "real" object like row is better here.Additional context and related issues
This was detected by the write-only object inspection in IDEA: the
hitBlockPositionObjectwas reported as never read from.Release notes
(x) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text: