Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get iceberg splits asynchronously #18425

Closed
wants to merge 1 commit into from

Conversation

lirui-apache
Copy link

Description

Get iceberg splits in a separate thread.

Additional context and related issues

Fixes #17631

@cla-bot
Copy link

cla-bot bot commented Jul 26, 2023

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Rui Li.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email [email protected]
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@github-actions github-actions bot added the iceberg Iceberg connector label Jul 26, 2023
@hashhar
Copy link
Member

hashhar commented Aug 9, 2023

cc: @alexjo2144

@alexjo2144
Copy link
Member

Do we have any benchmarks on if this improves planning time?

@lirui-apache
Copy link
Author

Hey @alexjo2144 , the purpose of the PR is not to improve planning time, but to avoid potential issue when planning with a blocking queue to reduce memory pressure. I put some background here.
As to performance, we've been using the proposed patch internally for about a year, and we haven't found any noticeable impact on planning time according the to getSplitDistribution metrics.

Copy link

This pull request has gone a while without any activity. Tagging the Trino developer relations team: @bitsondatadev @colebow @mosabua

@github-actions github-actions bot added the stale label Jan 11, 2024
@mosabua
Copy link
Member

mosabua commented Jan 11, 2024

@cla-bot check

Copy link

cla-bot bot commented Jan 11, 2024

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Rui Li.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email [email protected]
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

Copy link

cla-bot bot commented Jan 11, 2024

The cla-bot has been summoned, and re-checked this pull request!

@mosabua
Copy link
Member

mosabua commented Jan 11, 2024

@lirui-apache can you please submit a CLA?

@hashhar and @alexjo2144 can you help on reviewing this PR?

Copy link

cla-bot bot commented Jan 12, 2024

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@lirui-apache
Copy link
Author

Hi @mosabua , I have submitted my CLA and rebased the PR

@mosabua mosabua requested review from alexjo2144 and findepi January 12, 2024 16:06
@mosabua
Copy link
Member

mosabua commented Jan 12, 2024

@cla-bot check

Copy link

cla-bot bot commented Jan 12, 2024

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

Copy link

cla-bot bot commented Jan 12, 2024

The cla-bot has been summoned, and re-checked this pull request!

@mosabua
Copy link
Member

mosabua commented Jan 12, 2024

Looks like the CLA has to be processed yet. In the meantime I assigned reviewers and hope they can help out soon.

@github-actions github-actions bot removed the stale label Jan 12, 2024
Copy link

github-actions bot commented Feb 2, 2024

This pull request has gone a while without any activity. Tagging the Trino developer relations team: @bitsondatadev @colebow @mosabua

@github-actions github-actions bot added the stale label Feb 2, 2024
@mosabua
Copy link
Member

mosabua commented Feb 2, 2024

@cla-bot check

@cla-bot cla-bot bot added the cla-signed label Feb 2, 2024
Copy link

cla-bot bot commented Feb 2, 2024

The cla-bot has been summoned, and re-checked this pull request!

@github-actions github-actions bot removed the stale label Feb 5, 2024
Copy link

This pull request has gone a while without any activity. Tagging the Trino developer relations team: @bitsondatadev @colebow @mosabua

@github-actions github-actions bot added the stale label Feb 28, 2024
Copy link

Closing this pull request, as it has been stale for six weeks. Feel free to re-open at any time.

@github-actions github-actions bot closed this Mar 21, 2024
@mosabua
Copy link
Member

mosabua commented Mar 21, 2024

@alexjo2144 @electrum do we want to reopen and continue on this approach?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

Make IcebergSplitSource generate splits asynchronously
4 participants