-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get iceberg splits asynchronously #18425
Conversation
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Rui Li.
|
cc: @alexjo2144 |
Do we have any benchmarks on if this improves planning time? |
Hey @alexjo2144 , the purpose of the PR is not to improve planning time, but to avoid potential issue when planning with a blocking queue to reduce memory pressure. I put some background here. |
This pull request has gone a while without any activity. Tagging the Trino developer relations team: @bitsondatadev @colebow @mosabua |
@cla-bot check |
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Rui Li.
|
The cla-bot has been summoned, and re-checked this pull request! |
@lirui-apache can you please submit a CLA? @hashhar and @alexjo2144 can you help on reviewing this PR? |
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
Hi @mosabua , I have submitted my CLA and rebased the PR |
@cla-bot check |
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
The cla-bot has been summoned, and re-checked this pull request! |
Looks like the CLA has to be processed yet. In the meantime I assigned reviewers and hope they can help out soon. |
This pull request has gone a while without any activity. Tagging the Trino developer relations team: @bitsondatadev @colebow @mosabua |
@cla-bot check |
The cla-bot has been summoned, and re-checked this pull request! |
This pull request has gone a while without any activity. Tagging the Trino developer relations team: @bitsondatadev @colebow @mosabua |
Closing this pull request, as it has been stale for six weeks. Feel free to re-open at any time. |
@alexjo2144 @electrum do we want to reopen and continue on this approach? |
Description
Get iceberg splits in a separate thread.
Additional context and related issues
Fixes #17631