Add Exasol connector #16202

kaklakariada · 2023-02-21T12:49:37Z

Description

This adds a new connector for the analytics database Exasol.

This closes #16083.

Additional context and related issues

As discussed in #16011 the connector will be read-only for now.

Release notes

(x) Release notes are required, with the following suggested text:

# General
* Add read-only Exasol connector. ({issue}`16083`)

cla-bot · 2023-02-21T12:49:40Z

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

ebyhr

Could you add a documentation (docs/src/main/sphinx/connector/exasol.rst) and a product test (refer to TestClickHouse) and also update core/trino-server/src/main/provisio/trino.xml?

ebyhr

Just skimmed. Please squash commits into one.

plugin/trino-exasol/pom.xml

plugin/trino-exasol/src/main/java/io/trino/plugin/exasol/ExasolClient.java

plugin/trino-exasol/src/test/java/io/trino/plugin/exasol/AbstractTestExasolTypeMapping.java

plugin/trino-exasol/src/test/java/io/trino/plugin/exasol/TestExasolConnectorSmokeTest.java

plugin/trino-exasol/src/test/java/io/trino/plugin/exasol/TestExasolConnectorTest.java

plugin/trino-exasol/src/test/java/io/trino/plugin/exasol/TestExasolTypeMapping.java

plugin/trino-exasol/src/test/java/io/trino/plugin/exasol/TestingExasolServer.java

plugin/trino-exasol/src/main/java/io/trino/plugin/exasol/ExasolSessionProperties.java

kaklakariada · 2023-02-21T15:08:15Z

@ebyhr thank you very much for your review comments! I am not finished with the implementation yet and forgot to mark this PR as draft. I will address all of your findings.

cla-bot · 2023-02-21T15:13:47Z

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

cla-bot · 2023-02-22T05:28:19Z

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

cla-bot · 2023-02-27T06:57:07Z

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

cla-bot · 2023-02-28T14:56:57Z

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

cla-bot · 2023-02-28T15:01:15Z

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

cla-bot · 2023-02-28T15:26:53Z

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

cla-bot · 2023-03-02T08:23:35Z

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

cla-bot · 2023-03-02T10:24:41Z

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

cla-bot · 2023-03-02T10:31:02Z

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

cla-bot · 2023-03-02T11:46:03Z

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

cla-bot · 2023-03-02T13:41:39Z

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

cla-bot · 2023-03-02T13:54:23Z

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

cla-bot · 2023-03-02T14:02:30Z

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

cla-bot · 2023-03-02T14:11:47Z

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

kaklakariada · 2023-03-03T08:54:09Z

@ebyhr I sent the signed CLA to [email protected] on 2023-02-21 but the cla-bot keeps complaining. Do I need to do something else to fix this?

ebyhr · 2023-03-03T09:06:51Z

@martint Can we update https://github.com/trinodb/cla?

cla-bot · 2023-03-03T12:45:12Z

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

cla-bot · 2023-03-03T13:55:15Z

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

mosabua · 2024-04-05T18:28:08Z

We are still pursuing this to review and merge. Sorry for all the delays.

hashhar

Did a first pass, sorry about the delays.

plugin/trino-exasol/pom.xml

plugin/trino-exasol/src/main/java/io/trino/plugin/exasol/ExasolClient.java

plugin/trino-exasol/src/test/java/io/trino/plugin/exasol/TestExasolConnectorTest.java

hashhar · 2024-04-15T10:34:18Z

plugin/trino-exasol/src/test/java/io/trino/plugin/exasol/TestExasolConnectorTest.java

+    @Test
+    public void testCharTrailingSpace()
+    {
+        //super.testCharTrailingSpace();


reminder to self to revisit this

hashhar · 2024-04-15T10:35:03Z

plugin/trino-exasol/src/test/java/io/trino/plugin/exasol/TestExasolTypeMapping.java

+import static java.time.ZoneOffset.UTC;
+
+@Isolated
+public class TestExasolTypeMapping


reminder to self to revisit this.

plugin/trino-exasol/src/test/java/io/trino/plugin/exasol/TestingExasolServer.java

github-actions · 2024-05-13T17:43:37Z

This pull request has gone a while without any activity. Tagging the Trino developer relations team: @bitsondatadev @colebow @mosabua

mosabua · 2024-05-28T15:49:28Z

@hashhar @ebyhr ... are there any blocking issues that prevent a merge?

docs/src/main/sphinx/connector/exasol.md

plugin/trino-exasol/pom.xml

plugin/trino-exasol/src/test/java/io/trino/plugin/exasol/ExasolQueryRunner.java

plugin/trino-exasol/src/test/java/io/trino/plugin/exasol/TestExasolCaseInsensitiveMapping.java

plugin/trino-exasol/src/test/java/io/trino/plugin/exasol/TestExasolConnectorTest.java

docs/src/main/sphinx/connector/exasol.md

ebyhr · 2024-07-08T22:48:59Z

Looks good as the initial release though there are some remaining comments.

ebyhr reviewed Feb 21, 2023

View reviewed changes

kaklakariada marked this pull request as draft February 21, 2023 15:00

kaklakariada force-pushed the exasol-connector branch from b96d068 to 92f00b7 Compare February 28, 2023 15:26

github-actions bot added docs tests:hive labels Mar 2, 2023

kaklakariada force-pushed the exasol-connector branch from 90266f2 to d440593 Compare March 2, 2023 14:02

kaklakariada force-pushed the exasol-connector branch from d440593 to d905cbb Compare March 2, 2023 14:11

kaklakariada force-pushed the exasol-connector branch from d905cbb to 08b3877 Compare March 3, 2023 12:45

kaklakariada force-pushed the exasol-connector branch from 08b3877 to eba0aae Compare March 3, 2023 13:55

github-actions bot removed the stale label Apr 8, 2024

kaklakariada force-pushed the exasol-connector branch from 7155a0d to 292ee37 Compare April 11, 2024 08:35

hashhar reviewed Apr 15, 2024

View reviewed changes

findepi removed the tests:hive label Apr 18, 2024

kaklakariada force-pushed the exasol-connector branch 3 times, most recently from f5fcb81 to 8a2b4e1 Compare April 22, 2024 11:16

github-actions bot added the stale label May 13, 2024

mosabua added stale-ignore Use this label on PRs that should be ignored by the stale bot so they are not flagged or closed. and removed stale labels May 28, 2024

ebyhr reviewed Jun 10, 2024

View reviewed changes

kaklakariada force-pushed the exasol-connector branch 4 times, most recently from 18cb135 to d7d12e8 Compare June 10, 2024 14:24

mosabua reviewed Jun 11, 2024

View reviewed changes

docs/src/main/sphinx/connector/exasol.md Outdated Show resolved Hide resolved

mosabua reviewed Jun 11, 2024

View reviewed changes

docs/src/main/sphinx/connector/exasol.md Outdated Show resolved Hide resolved

kaklakariada force-pushed the exasol-connector branch from d7d12e8 to 7af5537 Compare June 12, 2024 05:29

kaklakariada force-pushed the exasol-connector branch from 7af5537 to 4ff1c41 Compare June 20, 2024 08:04

ebyhr force-pushed the exasol-connector branch from 4ff1c41 to d0b802a Compare July 8, 2024 22:36

Add Exasol connector

b152ff1

ebyhr force-pushed the exasol-connector branch from d0b802a to b152ff1 Compare July 8, 2024 22:38

ebyhr approved these changes Jul 8, 2024

View reviewed changes

ebyhr merged commit 6c41556 into trinodb:master Jul 11, 2024
99 checks passed

github-actions bot added this to the 452 milestone Jul 11, 2024

ebyhr mentioned this pull request Nov 27, 2024

Add Databend connector #23024

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Exasol connector #16202

Add Exasol connector #16202

kaklakariada commented Feb 21, 2023 •

edited by ebyhr

Loading

cla-bot bot commented Feb 21, 2023

ebyhr left a comment •

edited

Loading

ebyhr left a comment •

edited

Loading

kaklakariada commented Feb 21, 2023

cla-bot bot commented Feb 21, 2023

cla-bot bot commented Feb 22, 2023

cla-bot bot commented Feb 27, 2023

cla-bot bot commented Feb 28, 2023

cla-bot bot commented Feb 28, 2023

cla-bot bot commented Feb 28, 2023

cla-bot bot commented Mar 2, 2023

cla-bot bot commented Mar 2, 2023

cla-bot bot commented Mar 2, 2023

cla-bot bot commented Mar 2, 2023

cla-bot bot commented Mar 2, 2023

cla-bot bot commented Mar 2, 2023

cla-bot bot commented Mar 2, 2023

cla-bot bot commented Mar 2, 2023

kaklakariada commented Mar 3, 2023

ebyhr commented Mar 3, 2023

cla-bot bot commented Mar 3, 2023

cla-bot bot commented Mar 3, 2023

mosabua commented Apr 5, 2024

hashhar left a comment

hashhar Apr 15, 2024

hashhar Apr 15, 2024

github-actions bot commented May 13, 2024

mosabua commented May 28, 2024

ebyhr commented Jul 8, 2024

Add Exasol connector #16202

Add Exasol connector #16202

Conversation

kaklakariada commented Feb 21, 2023 • edited by ebyhr Loading

Description

Additional context and related issues

Release notes

cla-bot bot commented Feb 21, 2023

ebyhr left a comment • edited Loading

Choose a reason for hiding this comment

ebyhr left a comment • edited Loading

Choose a reason for hiding this comment

kaklakariada commented Feb 21, 2023

cla-bot bot commented Feb 21, 2023

cla-bot bot commented Feb 22, 2023

cla-bot bot commented Feb 27, 2023

cla-bot bot commented Feb 28, 2023

cla-bot bot commented Feb 28, 2023

cla-bot bot commented Feb 28, 2023

cla-bot bot commented Mar 2, 2023

cla-bot bot commented Mar 2, 2023

cla-bot bot commented Mar 2, 2023

cla-bot bot commented Mar 2, 2023

cla-bot bot commented Mar 2, 2023

cla-bot bot commented Mar 2, 2023

cla-bot bot commented Mar 2, 2023

cla-bot bot commented Mar 2, 2023

kaklakariada commented Mar 3, 2023

ebyhr commented Mar 3, 2023

cla-bot bot commented Mar 3, 2023

cla-bot bot commented Mar 3, 2023

mosabua commented Apr 5, 2024

hashhar left a comment

Choose a reason for hiding this comment

hashhar Apr 15, 2024

Choose a reason for hiding this comment

hashhar Apr 15, 2024

Choose a reason for hiding this comment

github-actions bot commented May 13, 2024

mosabua commented May 28, 2024

ebyhr commented Jul 8, 2024

kaklakariada commented Feb 21, 2023 •

edited by ebyhr

Loading

ebyhr left a comment •

edited

Loading

ebyhr left a comment •

edited

Loading