Mark spooling SPI as experimental to allow it's evolution

trinodb · Sep 25, 2024 · f934131 · f934131
1 parent 44ffc09
commit f934131
Show file tree

Hide file tree

Showing 7 changed files with 49 additions and 0 deletions.
diff --git a/core/trino-spi/pom.xml b/core/trino-spi/pom.xml
@@ -229,6 +229,42 @@
                                     <old>method long io.trino.spi.protocol.SpoolingContext::rowCount()</old>
                                     <justification>Align better when naming in other places</justification>
                                 </item>
+                                <item>
+                                    <ignore>true</ignore>
+                                    <code>java.class.removed</code>
+                                    <old>interface io.trino.spi.protocol.SpooledLocation</old>
+                                    <justification>Spooling SPI marked as experimental</justification>
+                                </item>
+                                <item>
+                                    <ignore>true</ignore>
+                                    <code>java.class.removed</code>
+                                    <old>interface io.trino.spi.protocol.SpooledSegmentHandle</old>
+                                    <justification>Spooling SPI marked as experimental</justification>
+                                </item>
+                                <item>
+                                    <ignore>true</ignore>
+                                    <code>java.class.removed</code>
+                                    <old>class io.trino.spi.protocol.SpoolingContext</old>
+                                    <justification>Spooling SPI marked as experimental</justification>
+                                </item>
+                                <item>
+                                    <ignore>true</ignore>
+                                    <code>java.class.removed</code>
+                                    <old>interface io.trino.spi.protocol.SpoolingManager</old>
+                                    <justification>Spooling SPI marked as experimental</justification>
+                                </item>
+                                <item>
+                                    <ignore>true</ignore>
+                                    <code>java.class.removed</code>
+                                    <old>interface io.trino.spi.protocol.SpoolingManagerContext</old>
+                                    <justification>Spooling SPI marked as experimental</justification>
+                                </item>
+                                <item>
+                                    <ignore>true</ignore>
+                                    <code>java.class.removed</code>
+                                    <old>interface io.trino.spi.protocol.SpoolingManagerFactory</old>
+                                    <justification>Spooling SPI marked as experimental</justification>
+                                </item>
                             </differences>
                         </revapi.differences>
                     </analysisConfiguration>

diff --git a/core/trino-spi/src/main/java/io/trino/spi/protocol/SpooledLocation.java b/core/trino-spi/src/main/java/io/trino/spi/protocol/SpooledLocation.java
@@ -14,13 +14,15 @@
 package io.trino.spi.protocol;
 
 import io.airlift.slice.Slice;
+import io.trino.spi.Experimental;
 
 import java.net.URI;
 import java.util.List;
 import java.util.Map;
 
 import static java.util.Objects.requireNonNull;
 
+@Experimental(eta = "2025-05-31")
 public sealed interface SpooledLocation
 {
     Map<String, List<String>> headers();

diff --git a/core/trino-spi/src/main/java/io/trino/spi/protocol/SpooledSegmentHandle.java b/core/trino-spi/src/main/java/io/trino/spi/protocol/SpooledSegmentHandle.java
@@ -13,13 +13,15 @@
  */
 package io.trino.spi.protocol;
 
+import io.trino.spi.Experimental;
 import io.trino.spi.QueryId;
 
 import java.time.Instant;
 
 /**
  * SpooledSegmentHandle is used to uniquely identify a spooled segment and to manage its lifecycle.
  */
+@Experimental(eta = "2025-05-31")
 public interface SpooledSegmentHandle
 {
     QueryId queryId();

diff --git a/core/trino-spi/src/main/java/io/trino/spi/protocol/SpoolingContext.java b/core/trino-spi/src/main/java/io/trino/spi/protocol/SpoolingContext.java
@@ -13,10 +13,12 @@
  */
 package io.trino.spi.protocol;
 
+import io.trino.spi.Experimental;
 import io.trino.spi.QueryId;
 
 import static java.util.Objects.requireNonNull;
 
+@Experimental(eta = "2025-05-31")
 public record SpoolingContext(String encoding, QueryId queryId, long rows, long size)
 {
     public SpoolingContext

diff --git a/core/trino-spi/src/main/java/io/trino/spi/protocol/SpoolingManager.java b/core/trino-spi/src/main/java/io/trino/spi/protocol/SpoolingManager.java
@@ -13,13 +13,15 @@
  */
 package io.trino.spi.protocol;
 
+import io.trino.spi.Experimental;
 import io.trino.spi.protocol.SpooledLocation.DirectLocation;
 
 import java.io.IOException;
 import java.io.InputStream;
 import java.io.OutputStream;
 import java.util.Optional;
 
+@Experimental(eta = "2025-05-31")
 public interface SpoolingManager
 {
     SpooledSegmentHandle create(SpoolingContext context);

diff --git a/core/trino-spi/src/main/java/io/trino/spi/protocol/SpoolingManagerContext.java b/core/trino-spi/src/main/java/io/trino/spi/protocol/SpoolingManagerContext.java
@@ -15,7 +15,9 @@
 
 import io.opentelemetry.api.OpenTelemetry;
 import io.opentelemetry.api.trace.Tracer;
+import io.trino.spi.Experimental;
 
+@Experimental(eta = "2025-05-31")
 public interface SpoolingManagerContext
 {
     default OpenTelemetry getOpenTelemetry()

diff --git a/core/trino-spi/src/main/java/io/trino/spi/protocol/SpoolingManagerFactory.java b/core/trino-spi/src/main/java/io/trino/spi/protocol/SpoolingManagerFactory.java
@@ -13,8 +13,11 @@
  */
 package io.trino.spi.protocol;
 
+import io.trino.spi.Experimental;
+
 import java.util.Map;
 
+@Experimental(eta = "2025-05-31")
 public interface SpoolingManagerFactory
 {
     String getName();