Migrate TestSystemConnector to integration test

trinodb · Oct 7, 2024 · f770c9b · f770c9b
1 parent 012cd02
commit f770c9b
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 124 deletions.
diff --git a/testing/trino-product-tests/src/main/java/io/trino/tests/product/TestSystemConnector.java b/testing/trino-product-tests/src/main/java/io/trino/tests/product/TestSystemConnector.java
diff --git a/...o-tests/src/test/java/io/trino/connector/system/metadata/TestSystemMetadataConnector.java b/...o-tests/src/test/java/io/trino/connector/system/metadata/TestSystemMetadataConnector.java
@@ -34,6 +34,7 @@
 import static io.trino.testing.MultisetAssertions.assertMultisetsEqual;
 import static io.trino.testing.TestingSession.testSessionBuilder;
 import static java.util.stream.Collectors.joining;
+import static org.assertj.core.api.Assertions.assertThat;
 import static org.junit.jupiter.api.parallel.ExecutionMode.SAME_THREAD;
 
 @Execution(SAME_THREAD) // CountingMockConnector is shared mutable state
@@ -72,6 +73,17 @@ protected QueryRunner createQueryRunner()
         }
     }
 
+    @Test
+    void testMetadataCatalogs()
+    {
+        assertThat(query("SELECT catalog_name, connector_id, connector_name FROM system.metadata.catalogs"))
+                .matches("VALUES " +
+                        "(CAST('system' AS VARCHAR), CAST('system' AS VARCHAR), CAST('system' AS VARCHAR))," +
+                        "(CAST('test_catalog' AS VARCHAR), CAST('test_catalog' AS VARCHAR), CAST('mock' AS VARCHAR))," +
+                        "(CAST('broken_catalog' AS VARCHAR), CAST('broken_catalog' AS VARCHAR), CAST('failing_mock' AS VARCHAR))," +
+                        "(CAST('tpch' AS VARCHAR), CAST('tpch' AS VARCHAR), CAST('tpch' AS VARCHAR))");
+    }
+
     @Test
     public void testTableCommentsMetadataCalls()
     {

diff --git a/...ino-tests/src/test/java/io/trino/connector/system/runtime/TestSystemRuntimeConnector.java b/...ino-tests/src/test/java/io/trino/connector/system/runtime/TestSystemRuntimeConnector.java
@@ -114,6 +114,13 @@ public void testRuntimeNodes()
                         "('testversion', false, 'active')");
     }
 
+    @Test
+    void testOptimizerRuleStats()
+    {
+        assertThat(query("SELECT rule_name, invocations, matches, failures FROM system.runtime.optimizer_rule_stats"))
+                .result().hasTypes(ImmutableList.of(VARCHAR, BIGINT, BIGINT, BIGINT));
+    }
+
     @Test
     public void testRuntimeQueriesTimestamps()
     {