Remove redundant TransactionLogTail.loadNewTail

trinodb · Mar 12, 2024 · ef3a573 · ef3a573
1 parent 84373d3
commit ef3a573
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 11 deletions.
diff --git a/...rino-delta-lake/src/main/java/io/trino/plugin/deltalake/transactionlog/TableSnapshot.java b/...rino-delta-lake/src/main/java/io/trino/plugin/deltalake/transactionlog/TableSnapshot.java
@@ -93,7 +93,7 @@ public static TableSnapshot load(
             throws IOException
     {
         Optional<Long> lastCheckpointVersion = lastCheckpoint.map(LastCheckpoint::getVersion);
-        TransactionLogTail transactionLogTail = TransactionLogTail.loadNewTail(fileSystem, tableLocation, lastCheckpointVersion);
+        TransactionLogTail transactionLogTail = TransactionLogTail.loadNewTail(fileSystem, tableLocation, lastCheckpointVersion, Optional.empty());
 
         return new TableSnapshot(
                 table,

diff --git a/...src/main/java/io/trino/plugin/deltalake/transactionlog/checkpoint/TransactionLogTail.java b/...src/main/java/io/trino/plugin/deltalake/transactionlog/checkpoint/TransactionLogTail.java
@@ -50,15 +50,6 @@ private TransactionLogTail(List<Transaction> entries, long version)
         this.version = version;
     }
 
-    public static TransactionLogTail loadNewTail(
-            TrinoFileSystem fileSystem,
-            String tableLocation,
-            Optional<Long> startVersion)
-            throws IOException
-    {
-        return loadNewTail(fileSystem, tableLocation, startVersion, Optional.empty());
-    }
-
     // Load a section of the Transaction Log JSON entries. Optionally from a given start version (exclusive) through an end version (inclusive)
     public static TransactionLogTail loadNewTail(
             TrinoFileSystem fileSystem,

diff --git a/...test/java/io/trino/plugin/deltalake/transactionlog/checkpoint/TestTransactionLogTail.java b/...test/java/io/trino/plugin/deltalake/transactionlog/checkpoint/TestTransactionLogTail.java
@@ -59,7 +59,7 @@ private List<DeltaLakeTransactionLogEntry> readJsonTransactionLogTails(String ta
             throws Exception
     {
         TrinoFileSystem fileSystem = new HdfsFileSystemFactory(HDFS_ENVIRONMENT, HDFS_FILE_SYSTEM_STATS).create(SESSION);
-        TransactionLogTail transactionLogTail = TransactionLogTail.loadNewTail(fileSystem, tableLocation, Optional.of(10L));
+        TransactionLogTail transactionLogTail = TransactionLogTail.loadNewTail(fileSystem, tableLocation, Optional.of(10L), Optional.empty());
         return transactionLogTail.getFileEntries();
     }
 }