Return early if http client is already closed

trinodb · Dec 3, 2024 · 4de3e5a · 4de3e5a
1 parent 4181ea6
commit 4de3e5a
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/core/trino-main/src/main/java/io/trino/operator/DirectExchangeClient.java b/core/trino-main/src/main/java/io/trino/operator/DirectExchangeClient.java
@@ -330,7 +330,11 @@ Map<URI, HttpPageBufferClient> getAllClients()
 
     private boolean addPages(HttpPageBufferClient client, List<Slice> pages)
     {
-        checkState(!completedClients.contains(client), "client is already marked as completed");
+        // If client is already completed, addPages is a no-op
+        if (completedClients.contains(client)) {
+            return false;
+        }
+
         // Compute stats before acquiring the lock
         long responseSize = 0;
         if (!pages.isEmpty()) {