Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support custom request headers #91

Closed
wants to merge 1 commit into from

Conversation

patrickdemers6
Copy link

Depending on the Trino server configuration, the ability to pass custom headers on a per-request is incredibly valuable. Transaction ID, instrumentation ID, and Authorization headers to name a few. This adds the ability to set custom headers using a sql.Named parameter where the name has the prefix X-Header-.

Testing

  1. Unit test in trino_test.go.
  2. Manually validated with a local Trino server.

I signed CLA earlier today but it may not be in the system yet.

@cla-bot
Copy link

cla-bot bot commented Oct 11, 2023

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Patrick Demers.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email [email protected]
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@cla-bot
Copy link

cla-bot bot commented Oct 11, 2023

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@cla-bot
Copy link

cla-bot bot commented Oct 12, 2023

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@nineinchnick
Copy link
Member

There's a similar discussion in the main Trino repository: trinodb/trino#15826. I think it also applies here. I'd rather discuss specific use cases and keep Trino clients in multiple languages consistent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants