Add service monitor API version override #266
Conversation
|
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
…hart version changes
|
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
charts/trino/values.yaml
Outdated
| @@ -948,6 +948,8 @@ serviceMonitor: | |||
| # serviceMonitor.enabled -- Set to true to create resources for the | |||
| # [prometheus-operator](https://github.com/prometheus-operator/prometheus-operator). | |||
| enabled: false | |||
| # serviceMonitor.apiVersion -- API version for serviceMonitor | |||
There was a problem hiding this comment.
Remove the docs, they're not helpful - it's basically the same as the property name.
|
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
This feature enables users to override the Service Monitor API version if they are using Azure managed prometheus which uses
azmonitoring.coreos.com/v1instead of the defaultmonitoring.coreos.com/v1.