fix

trim21 · Nov 25, 2024 · a381442 · a381442
1 parent 61c46bc
commit a381442
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 0 deletions.
diff --git a/internal/metrics/metrics.go b/internal/metrics/metrics.go
@@ -23,6 +23,7 @@ func init() {
 	prometheus.MustRegister(RequestCount)
 	prometheus.MustRegister(RequestHistogram)
 	prometheus.MustRegister(SQLHistogram)
+
 }
 
 var RequestCount = prometheus.NewCounter(prometheus.CounterOpts{

diff --git a/internal/tag/cache_repo.go b/internal/tag/cache_repo.go
@@ -18,6 +18,7 @@ import (
 	"context"
 	"time"
 
+	"github.com/prometheus/client_golang/prometheus"
 	"github.com/samber/lo"
 	"github.com/trim21/errgo"
 	"go.uber.org/zap"
@@ -44,6 +45,25 @@ type cachedTags struct {
 	Tags []Tag
 }
 
+var CacheCount = prometheus.NewCounter(prometheus.CounterOpts{
+	Subsystem:   "chii",
+	Name:        "request_cached_count",
+	Help:        "",
+	ConstLabels: map[string]string{"repo": "meta_tags"},
+})
+
+var NotCacheCount = prometheus.NewCounter(prometheus.CounterOpts{
+	Subsystem:   "chii",
+	Name:        "request_not_cached_count",
+	Help:        "",
+	ConstLabels: map[string]string{"repo": "meta_tags"},
+})
+
+func init() {
+	prometheus.MustRegister(CacheCount)
+	prometheus.MustRegister(NotCacheCount)
+}
+
 func (r cacheRepo) Get(ctx context.Context, id model.SubjectID) ([]Tag, error) {
 	var key = cachekey.SubjectMetaTag(id)
 
@@ -54,8 +74,10 @@ func (r cacheRepo) Get(ctx context.Context, id model.SubjectID) ([]Tag, error) {
 	}
 
 	if ok {
+		CacheCount.Add(1)
 		return s.Tags, nil
 	}
+	NotCacheCount.Add(1)
 
 	tags, err := r.repo.Get(ctx, id)
 	if err != nil {
@@ -86,6 +108,7 @@ func (r cacheRepo) GetByIDs(ctx context.Context, ids []model.SubjectID) (map[mod
 		return nil, errgo.Wrap(err, "cache.MGet")
 	}
 
+	CacheCount.Add(float64(len(tags)))
 	for _, tag := range tags {
 		result[tag.ID] = tag.Tags
 	}
@@ -97,6 +120,7 @@ func (r cacheRepo) GetByIDs(ctx context.Context, ids []model.SubjectID) (map[mod
 		}
 	}
 
+	NotCacheCount.Add(float64(len(missing)))
 	missingFromCache, err := r.repo.GetByIDs(ctx, missing)
 	if err != nil {
 		return nil, err