Develop #31
Open
Develop #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naman-TI
suggested changes
Dec 15, 2022
| return | ||
| logger.info("Calling validation service") | ||
| async with httpx.AsyncClient() as client: # 3 |
| try: | ||
| # process the dict |
There was a problem hiding this comment.
what is handled here? you can handle keyerror and valueerror in this
| @@ -31,22 +31,26 @@ | |||
| you will get the idea about the part when you go through the code. | |||
| """ | |||
|
|
|||
There was a problem hiding this comment.
handle exceptions wherever external APIs are used in this file.
fast_api_als/database/db_helper.py
Outdated
| @@ -16,6 +16,7 @@ | |||
| write a commong function that logs this response code with appropriate context data | |||
| """ | |||
|
|
|||
| logger = logging.getLogger() | |||
There was a problem hiding this comment.
use a Module level logger to get usable logs
There was a problem hiding this comment.
I am not able to get the difference between logger and direct logging function of module.
There was a problem hiding this comment.
use logger = logging.getLogger(__name__) in different modules to use a module-level logger
|
This is done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.