Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add generic error message for send operation #2185

Merged
merged 6 commits into from
Dec 6, 2024

Conversation

OKendigelyan
Copy link
Contributor

@OKendigelyan OKendigelyan commented Dec 3, 2024

Proposed changes

This PR replaces detailed error messages with generic ones to hide potential sensitive information and make it more user friendly.

Copy link

vercel bot commented Dec 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
umami-embed-iframe ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 6, 2024 0:37am
umami-embed-iframe-ghostnet ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 6, 2024 0:37am
umami-v2-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 6, 2024 0:37am
umami-v2-web-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 6, 2024 0:37am

@OKendigelyan OKendigelyan force-pushed the fix-error-message-for-send branch from 6802a24 to 0f75bbe Compare December 3, 2024 14:14
@OKendigelyan OKendigelyan force-pushed the fix-error-message-for-send branch from 0f75bbe to 1392f11 Compare December 4, 2024 10:12
@OKendigelyan OKendigelyan force-pushed the fix-error-message-for-send branch from 525b30d to 2a30772 Compare December 5, 2024 14:44
@OKendigelyan OKendigelyan marked this pull request as ready for review December 5, 2024 14:44
@OKendigelyan OKendigelyan force-pushed the fix-error-message-for-send branch 2 times, most recently from fd3784d to dfa22cd Compare December 5, 2024 14:47
@OKendigelyan OKendigelyan force-pushed the fix-error-message-for-send branch from dfa22cd to e0e4e49 Compare December 5, 2024 14:48
@OKendigelyan OKendigelyan enabled auto-merge (squash) December 5, 2024 14:49
@OKendigelyan OKendigelyan force-pushed the fix-error-message-for-send branch from e0e4e49 to 0ba2d0e Compare December 5, 2024 14:56
@OKendigelyan OKendigelyan disabled auto-merge December 5, 2024 15:42
@ajinkyaraj-23
Copy link
Collaborator

Created an issue for "too generic error msgs for input validation/secret key validation in restore secret key form". Can be addressed later.

Copy link
Collaborator

@ajinkyaraj-23 ajinkyaraj-23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OKendigelyan
Copy link
Contributor Author

ajinkyaraj-23 merged commit b3ef307 into main Dec 6, 2024

fixed here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants