feat: WalletConnect integration, part 6, request #2029
+192
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dianasavvatina
force-pushed
the
add-wc-request
branch
from
77af87f to
cb4af5c
Compare
dianasavvatina
changed the title
dianasavvatina
force-pushed
the
add-wc-request
branch
from
cb4af5c to
d84142d
Compare
dianasavvatina
force-pushed
the
add-wc-request
branch
from
d84142d to
1bf9402
Compare
dianasavvatina
force-pushed
the
add-wc-request
branch
from
1bf9402 to
e39c43a
Compare
dianasavvatina
force-pushed
the
add-wc-request
branch
from
e39c43a to
d6b398e
Compare
dianasavvatina
force-pushed
the
add-wc-request
branch
from
d6b398e to
7c0b44d
Compare
dianasavvatina
force-pushed
the
add-wc-request
branch
from
eb983e1 to
6fbbfd2
Compare
dianasavvatina
force-pushed
the
add-wc-request
branch
from
6fbbfd2 to
4f823e4
Compare
dianasavvatina
force-pushed
the
add-wc-request
branch
from
4f823e4 to
ac2b1c3
Compare
dianasavvatina
force-pushed
the
add-wc-request
branch
from
ac2b1c3 to
0748cee
Compare
requests are supported. Tested: - send tez - delegate / undelegate - originate / call contract - stake / unstake / finalize unstake
dianasavvatina
force-pushed
the
add-wc-request
branch
from
0748cee to
17d9d12
Compare
OKendigelyan
requested changes
Dec 12, 2024
| import { SuccessStep } from "../SuccessStep"; | ||
| import { type CalculatedSignProps, type SdkSignPageProps } from "../utils"; | ||
|
|
||
| export const useSignWithWalletConnect = ({ |
There was a problem hiding this comment.
please align the file name with the function
| return openWith(<SuccessStep hash={opHash} />); | ||
| }, | ||
| error => ({ | ||
| description: `Failed to confirm Beacon operation: ${error.message}`, |
There was a problem hiding this comment.
Beacon operation in WC handler?
|
|
||
| case "tezos_send": { | ||
| if (!request.params.account) { | ||
| throw new Error("Missing account in request"); |
There was a problem hiding this comment.
here and in other places we need to use CustomError class for the custom errors
| if (!network) { | ||
| const response = formatJsonRpcError(id, getSdkError("INVALID_EVENT").message); | ||
| await walletKit.respondSessionRequest({ topic, response }); | ||
| toast({ description: `Unsupported network: ${chainId}`, status: "error" }); |
There was a problem hiding this comment.
basically we can throw an CustomError and it should be handled inside handleAsyncActionUnsafe
| throw new Error(`Unsupported method ${request.method}`); | ||
| } | ||
| } | ||
| // error => ({ |
There was a problem hiding this comment.
do we need this comment?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
requests are supported. Tested:
- send tez
- delegate / UndelegationSignPage
- originate / call contract
- stake / unstake / finalize unstake
- increase paid storage (rejected as not supported by Umami)
Types of changes
Steps to reproduce
Screenshots
Checklist