Add support for macOS #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjorn3
force-pushed
the
macos_support
branch
2 times, most recently
from
812eb8c
to
3bfbd5f
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
|
bjorn3
force-pushed
the
macos_support
branch
6 times, most recently
from
b5ca3d4
to
cd51d74
Compare
folkertdev
approved these changes
Nov 12, 2024
Comment on lines
+13
to
19
| // FIXME remove this | ||
| extern "C" { | ||
| static stdin: *mut FILE; | ||
| static stdout: *mut FILE; | ||
| #[cfg_attr(target_os = "macos", link_name = "__stdinp")] | ||
| static mut stdin: *mut FILE; | ||
| #[cfg_attr(target_os = "macos", link_name = "__stdoutp")] | ||
| static mut stdout: *mut FILE; | ||
| } |
There was a problem hiding this comment.
yeah these are also a problem on windows, leading me to suspect that this binary was not actually cross-platform . Invalid windows paths are handled, but this would not even build on windows...
There was a problem hiding this comment.
In C stdin and stdout are macros which expand to a libc specific expression. Unfortunately the libc crate doesn't provide the definitions of these macros, so we have to manually write their expansion instead.
bjorn3
force-pushed
the
macos_support
branch
from
cd51d74
to
9999c38
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.