Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix order of bins #101

Merged
merged 22 commits into from
Feb 8, 2023
Merged

Fix order of bins #101

merged 22 commits into from
Feb 8, 2023

Conversation

damianooldoni
Copy link
Collaborator

@damianooldoni damianooldoni commented Feb 8, 2023 •
edited
Loading

This PR:

  1. fix Order of year bins in visualize_pathways_year_level1 #100 by using a if structure while reordering the levels of the bins columns.
  2. fix same issue on the similar function for level2 (as mentioned in Order of year bins in visualize_pathways_year_level1 #100 as well)
  3. Add unit-tests for 1. and 2.
  4. Fix typos in documentation
  5. Use test_path to read paths for data used in tests
  6. Improve documentation of gbif_verify_taxa and add fast fix in correspondent tests due to issue with GBIF API while retrieving occurrenceStatus distribution data (see occurrenceStatus missing in API species distribution enpoint gbif/gbif-api#94)
  7. Remove testthat:: from test files (not a good practice)
  8. Avoid tidyselect warning while using .data in dplyr::select() and dplyr::rename

Still to do: solve warnings. Such warnings could result in failing automatic checks now. See #102

@damianooldoni
Fix #100
ffdd5fd
@damianooldoni
Update Roxygen vresion
3681880
@damianooldoni
Increment version number to 2.0.4
ed11cd3
@damianooldoni
Add tests level1
6bc102a 
Checks based on #100 bug description
@damianooldoni
Remove testthat::
9eeaecc
@damianooldoni
Load testthat once
010a94b
@damianooldoni
Remove testthat:: from level1 tests
c2dae4b
@damianooldoni
Use system.file to locate files in tests
d6dd493
@damianooldoni
Improve tests for level2 based on #100
fb016e4
@damianooldoni
Use system.file() for reading files in tests
35b3b0f
@damianooldoni
Avoid warning based on use of .data
41f6dd8 
Based on new version of tidyselect, see r-lib/tidyselect#169
@damianooldoni
Avoid some warnings for .data and remove testthat::
74c9630
@damianooldoni
Use system.file() to read data inputs for tests
63483da
@damianooldoni
Use pkg::function syntax instead of @importFrom
bcc09e1
@damianooldoni
Add removed line
19cc66b
@damianooldoni
Revert changes to verify_taxa
a12bead
@damianooldoni
Remove typo in documentation
151f631
@damianooldoni
Use system.file to read files for tests
c1396c7
@damianooldoni
Do not control order of names() - only presence
97f46df
@damianooldoni
Modify doc and tests based on GIBF API open issue
b941453
@damianooldoni
Use test_path to read files for tests
3a3c779
@damianooldoni
Solve test failure names of gratia::derivatives output
523f44c 
IT seems that two new cols appeared with new R version/new version of gratia package.
@damianooldoni damianooldoni merged commit 1ca7d04 into main Feb 8, 2023
@damianooldoni damianooldoni deleted the fix-100 branch April 11, 2024 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Order of year bins in visualize_pathways_year_level1
1 participant
@damianooldoni