Marked ResolveUrlTokenFilter as final. Also.. #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…that can be defined as parameter to externalize url resolution logic. Added junit maven dependency. Added test verifying logic of custom token filter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additionally, I added a UrlResolver interface that can be defined as parameter to externalize url resolution logic. This logic is demonstrated in a unit test as well. SOLR is very new to me. I'm not sure if defining the class as a parameter is a silly idea. If it is, I wouldn't mind reverting those changes.
IMHO, the only necessary change is marking the custom TokenFilter implementation as final.