use rpm in SLE Dockerfile #481
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arbulu89
reviewed
Jul 10, 2024
packaging/suse/container/Dockerfile
Outdated
| LABEL org.opencontainers.image.source="https://github.com/trento-project/wanda" | ||
| LABEL org.opencontainers.image.version="%%VERSION%%-build%RELEASE%" | ||
| # endendlabelprefix |
There was a problem hiding this comment.
is this double end intentional?
There was a problem hiding this comment.
definitely a typo!
yes |
since we now have the rpm we don't need to build the binary within a container build, we can just zypper install it
stefanotorresi
force-pushed
the
stefanotorresi-update-sle-container
branch
from
3d287d6 to
413483f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
since we now have the rpm we don't need to build the binary within a container build, we can just zypper install it